From owner-cvs-all@FreeBSD.ORG Wed Apr 2 10:23:53 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1D3B037B407 for ; Wed, 2 Apr 2003 10:23:53 -0800 (PST) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 9462043FCB for ; Wed, 2 Apr 2003 10:23:51 -0800 (PST) (envelope-from nate@rootlabs.com) Received: (qmail 11976 invoked by uid 1000); 2 Apr 2003 18:23:52 -0000 Date: Wed, 2 Apr 2003 10:23:52 -0800 (PST) From: Nate Lawson To: Maxime Henrion In-Reply-To: <20030402164726.ACB6737B401@hub.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c if_fxpreg.h if_fxpvar.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Apr 2003 18:23:53 -0000 On Wed, 2 Apr 2003, Maxime Henrion wrote: > Modified files: > sys/dev/fxp if_fxp.c if_fxpreg.h if_fxpvar.h > Log: > Convert the fxp(4) driver to the busdma API. > > This patch is rather big because I had to significantly redesign > the driver to make the busdma conversion possible. Most notably, > hardware and software structures were carefully splitted to get > rid of all the structs overlapping evilness. Nice! I have some locking patches for fxp that I'll post soon. It looks like some nice comments were removed in your diff. It would be good if you rewrote equivalent ones based on the change in behavior. -Nate