From owner-freebsd-current@freebsd.org Wed Feb 12 17:22:56 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AB6AD23E106 for ; Wed, 12 Feb 2020 17:22:56 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 48HmgN36V0z4gKY for ; Wed, 12 Feb 2020 17:22:56 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id 01CHMsmn004324 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 12 Feb 2020 09:22:54 -0800 (PST) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id 01CHMsSu004323; Wed, 12 Feb 2020 09:22:54 -0800 (PST) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@freebsd.org using -f Date: Wed, 12 Feb 2020 09:22:54 -0800 From: Gleb Smirnoff To: yp@mm.st Cc: freebsd-current@freebsd.org Subject: Re: panic: Assertion in_epoch(net_epoch_preempt) failed, r357793 Message-ID: <20200212172254.GC1253@FreeBSD.org> References: <1123c163-846f-7264-febd-3027e1b17369@mm.st> <20200212163824.GA1253@FreeBSD.org> <20200212171832.GB1253@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200212171832.GB1253@FreeBSD.org> X-Rspamd-Queue-Id: 48HmgN36V0z4gKY X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.94 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.97)[-0.966,0]; NEURAL_HAM_LONG(-0.98)[-0.975,0]; ASN(0.00)[asn:27348, ipnet:162.251.186.0/24, country:US] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Feb 2020 17:22:56 -0000 On Wed, Feb 12, 2020 at 09:18:32AM -0800, Gleb Smirnoff wrote: T> On Wed, Feb 12, 2020 at 07:41:54PM +0300, yp@mm.st wrote: T> y> Gleb Smirnoff wrote: T> y> > On Wed, Feb 12, 2020 at 09:49:12AM +0300, yp@mm.st wrote: T> y> > y> Getting the following panic after updating to r357793 (expect typos, hand T> y> > y> copied): T> y> > y> T> y> > y> panic: Assertion in_epoch(net_epoch_preempt) failed at T> y> > y> /usr/src/sys/net/iflib.c:2762 T> y> > y> T> y> > y> db_trace_self_wrapper() T> y> > y> vpanic() T> y> > y> panic() T> y> > y> iflib_rxeof() T> y> > y> _task_fn_rx() T> y> > y> gtaskqueue_run_locked() T> y> > y> gtaskqueue_thread_loop() T> y> > y> fork_exit() T> y> > y> fork_trampoline() T> y> > y> --- trap 0, rip = 0, rsp = 0, rbp = 0 --- T> y> > T> y> > Are you running iflib as a loadable module? Your trace clearly T> y> > has _task_fn_rx(), and Hans's patch covers _task_fn_tx(). However, T> y> > Hans's patch helped you. So, my guess is happen just due to T> y> > recompilation and reinstall of the module, not due to patch. T> y> T> y> No, it was a clean install from latest snapshot ISO, updated to that T> y> revision using the usual {build,install}{world,kernel} procedure without T> y> any settings in src.conf and using GENERIC conf, so iflib is builtin. T> T> Sorry, Hans's patch is correct. I didn't notice the alternative T> initializer of taskqueue. Strange that this didn't pop up with T> my igb0. Will fix in few minutes. Hans already checked in his patch. Great! -- Gleb Smirnoff