From owner-freebsd-multimedia@freebsd.org Sat Aug 8 09:18:57 2020 Return-Path: Delivered-To: freebsd-multimedia@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E47E93A4C59 for ; Sat, 8 Aug 2020 09:18:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4BNxVn5rkRz4XDv for ; Sat, 8 Aug 2020 09:18:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id C8C4E3A5049; Sat, 8 Aug 2020 09:18:57 +0000 (UTC) Delivered-To: multimedia@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C88D93A4CE2 for ; Sat, 8 Aug 2020 09:18:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BNxVn51rpz4XDt for ; Sat, 8 Aug 2020 09:18:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 8FC59265EE for ; Sat, 8 Aug 2020 09:18:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 0789Iv3J063054 for ; Sat, 8 Aug 2020 09:18:57 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 0789IvZ5063053 for multimedia@FreeBSD.org; Sat, 8 Aug 2020 09:18:57 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: multimedia@FreeBSD.org Subject: maintainer-feedback requested: [Bug 248533] audio/libsndfile: Setting TEST=ON breaks compatibility with dependent ports Date: Sat, 08 Aug 2020 09:18:57 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: multimedia@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Aug 2020 09:18:58 -0000 Bugzilla Automation has asked freebsd-multimedia (Nobody) for maintainer-feedback: Bug 248533: audio/libsndfile: Setting TEST=3DON breaks compatibility with dependent ports https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D248533 --- Description --- Ports including audio/libsamplerate, audio/pulseaudio and audio/twolame dep= end on the shared library libsndfile.so, installed by audio/libsndfile. However, with STATIC=3DON, audio/libsndfile instead produces the static lib= rary libsndfile.a. Setting TEST=3DON also sets STATIC=3DON, I believe due to the following lin= e in the Makefile: TEST_IMPLIES=3D STATIC This means that libsndfile.so is not available for dependent ports. I have attached poudriere testport logs for audio/libsndfile with TEST=3DON and fo= r an example dependent port audio/libsamplerate. In my humble opinion, enabling testing during the port build should not bre= ak compatibility with dependent ports. Can testing be achieved in a different way? For now, the workaround is to build with TEST=3DOFF.