From nobody Sat May 4 00:09:44 2024 X-Original-To: freebsd-stable@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VWSj53CbFz5JpVX for ; Sat, 4 May 2024 00:09:45 +0000 (UTC) (envelope-from brooks@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VWSj5129Rz4p3c; Sat, 4 May 2024 00:09:45 +0000 (UTC) (envelope-from brooks@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714781385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pqdR6zlBCMCvKA8GL0/jrivYkDID74BB3r+MD2sKAAA=; b=cWAzH8pcs01xWLXrIUjf51YVAqTJezMv4WnKiWjWA0zcjjzUC/YJbXJrKETyI3D1wscC1A XqZLGzDckeElC+r2h5DkYFfH+D3VEranSL2ZJMBcpxUzxbMScvdLMYizn7cXeJ52fJDJiW QoBcOz0+hji6Xv4wjmfreuxTrANp4+hys5ksRS3dlJSr9AyfNmw0BCGTA8h0DaJpjLvUPX s5/ien8CI+klN1LUoLZ4sdPrYG4mpzygGhFZksOScc73l4c6qGB2UXqGankWQ3jcWmSd+B tM5LmvUTUfJgJd8htwMmfnIJkEsOw/Rw/b8GcZWR4tVYOAxH0TpZRo4xAhcHzg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1714781385; a=rsa-sha256; cv=none; b=WS/zMW5E2bmln9GNPhYFstOqV0TUdM4B7BOcu1brqQN91++oxYFEZNToCTvWOhP3lJCGGW wo/JgC/SRb2pYqiEVgf7Vfh4y8IYmFKLQeoGYXTLRmPQTjE7Q44CbjUhMOt6tXP/6iQUD0 0RBmdypv37Jzkam9pSdfXjCQ92NupilWFNwCOxyLo0MhMCBYWGOnAj8ADsznJpYks+dfE+ 5su5W5CnsgAwZN7rOxj7Rxm7ttq0qstzjG/nlqDctMshqLMNc+S0/I8+ZG3ZcT+E7Y5Ux1 5+J9CPsZlgjzMXIFomxYMvFYBmZWXIYrwAay0azMRkGzWdISFFncX91kEtaZqA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714781385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pqdR6zlBCMCvKA8GL0/jrivYkDID74BB3r+MD2sKAAA=; b=HvF9oqRS0HWoijNWtPtB89zZgXrbkVR+40CQq7Vidl3T+7hP/Dn2K97fIBvo2uLhzJF+4v xrmR6gpQZuN17u+UqvwYVBsEPJ4zOzL11qWx/hojr+gVte2f9pVHi/ys8TJgE8bPtLhpdl o+GXcgfflaiELa7DuY1hJDnHBRj0myu9/XMSn1B+wzQaNSXu0+5hBdolJt/NSBRUCG0AJK HrwDGoNyVMrBp0EDAe8WqFE80LDUVjxw4uU7bRsf+6345fLlcXsfAT/9ZodOSRLBgu3fB2 RGu0wDA5VkVYo9CEsawO9KktE6MdWSdMHz7e75rh0tcEITSPAb6/IpQgybZhBA== Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: brooks/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VWSj50PHSzyRG; Sat, 4 May 2024 00:09:45 +0000 (UTC) (envelope-from brooks@freebsd.org) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 4925D3C019B; Sat, 4 May 2024 00:09:44 +0000 (UTC) Date: Sat, 4 May 2024 00:09:44 +0000 From: Brooks Davis To: Garrett Wollman Cc: freebsd-stable@freebsd.org Subject: Re: ZFS property inheritance broken for `readonly`? Message-ID: References: <26165.22926.598276.904906@hergotha.csail.mit.edu> List-Id: Production branch of FreeBSD source code List-Archive: https://lists.freebsd.org/archives/freebsd-stable List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-stable@freebsd.org Sender: owner-freebsd-stable@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <26165.22926.598276.904906@hergotha.csail.mit.edu> On Fri, May 03, 2024 at 05:39:26PM -0400, Garrett Wollman wrote: > I've noticed recently (not sure when this started, maybe on the 12->13 > transition, which would be the same as the old ZFS to OpenZFS > transition for us) that inheritance for the `readonly` property is > broken. > > Here is an example: > > [root@nfs-prod-11 /home/wollman]# zfs set readonly=on export/cl > [root@nfs-prod-11 /home/wollman]# zfs get readonly export/cl/u > NAME PROPERTY VALUE SOURCE > export/cl/u readonly off temporary > > The child filesystem `export/cl/u` should have inherited the readonly > setting from `export/cl` but instead it (and all other children) have > overridden it, and I have to manually `zfs inherit readonly` on all of > the children to get the proper behavior. This is quite surprising, > and the first time it happened I was sure that something had gone > wrong. I find myself wondering if ZFS was unable to downgrade the mount and this is a transient state, but the fact that inherit works suggests otherwise. I suppose it could be a missing case in the spl layer. -- Brooks