From nobody Fri Apr 21 17:55:36 2023 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q32Ht1h3jz46h1D for ; Fri, 21 Apr 2023 17:55:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q32Hs6LG6z3y7f for ; Fri, 21 Apr 2023 17:55:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682099737; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YuoTfR6pmAVuPPHT6OpUHY73NjPMf2RxS6YutxQZZi4=; b=Sy9dMgmVSgMP2MvQFRYErIvshZtcdWzVo/7n5UbIApsaNSQ4nkocU3eiZZCSvZIrIcJUZB Mg+z1fUStdUIquDuQSX/DhaKpmEk+jcdhesfPlu5+p/In2HVfSdrcDxGzE1ixeFxP/pXyD enq6E8Gz1qCtsCP1vTxbp01Eg2f/JxvV2VBxMQqp7OUKaJWObIQ9LbURhA8MEwZtEdh44G q2XCyamXk2rJNAVNencVIVcVXzWVcSbP4aPwH3sOmBw2b3jgv/9J1EkmSiiuSUhGSPztzJ ggc1kEMyhGvyRZ5SX2DXffziU54R3V1tPHPIwEdstvzxMV3tZN8Wj7mdRBlFMw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1682099737; a=rsa-sha256; cv=none; b=SrGPf64RoDi75A1soFK+WfPcwMmNHf4/9wyXQTAsW0pj2PCCLmfTu0jw0qOT9Tflyk6v28 O8Xmu6X5qlSTO9KOFXghpZ2reTK7abryTurBSmiAGk4L2xRs0jLuffk5v19W6okUMSqMKV KBoTR+ccLW4wyV8iIaTrTOW/cgLXWM2PUPV2sOkP0XwMMkqNqgI0KtQ5hGJrhl2HFUekAw dFHl+C8p77Qy0UV2zTSqFuyd6aaKhmwtouv8bJ2rqtkWGyHUqP6zaSuc+C+CaYxxegCsCl YLcQJsLuPqBvqLSF1WtnyyS7aCYIEMarha1j5+jBM+Fjg9OScMFKn/wgc0ICsQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Q32Hs5N6fzV60 for ; Fri, 21 Apr 2023 17:55:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 33LHtbTa020576 for ; Fri, 21 Apr 2023 17:55:37 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 33LHtbl5020575 for fs@FreeBSD.org; Fri, 21 Apr 2023 17:55:37 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 270811] ZFS/PowerPC: Issue after openzfs/zfs@431083f75 import Date: Fri, 21 Apr 2023 17:55:36 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: crash X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: mjg@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D270811 --- Comment #10 from Mateusz Guzik --- /usr/local/src/base/sys/contrib/openzfs/module/zfs/zio_checksum.c:527 97 SET_ERROR zio_checksum_error_impl /usr/local/src/base/sys/contrib/openzfs/module/zfs/zio_checksum.c:527 97 SET_ERROR zio_checksum_error_impl /usr/local/src/base/sys/contrib/openzfs/module/zfs/zio_checksum.c:527 97 SET_ERROR zio_checksum_error_impl /usr/local/src/base/sys/contrib/openzfs/module/zfs/zio_checksum.c:527 97 SET_ERROR zio_checksum_error_impl /usr/local/src/base/sys/contrib/openzfs/module/zfs/zio_checksum.c:527 97 SET_ERROR zio_checksum_error_impl /usr/local/src/base/sys/contrib/openzfs/module/zfs/zio_checksum.c:527 97 SET_ERROR spa_ld_validate_vdevs /usr/local/src/base/sys/contrib/openzfs/module/zfs/spa.c:3582 6 As in: if (!ZIO_CHECKSUM_EQUAL(actual_cksum, expected_cksum)) return (SET_ERROR(ECKSUM)); and finally: if (rvd->vdev_state <=3D VDEV_STATE_CANT_OPEN) { spa_load_failed(spa, "cannot open vdev tree after invalidat= ing " "some vdevs"); vdev_dbgmsg_print_tree(rvd, 2); return (SET_ERROR(ENXIO)); } as all checksum checks failed iow the new checksum routines return a different result than the original. add this on top of the other stuff: diff --git a/sys/contrib/openzfs/module/zfs/zio_checksum.c b/sys/contrib/openzfs/module/zfs/zio_checksum.c index 6090959c5b8c..581c3ccb82e8 100644 --- a/sys/contrib/openzfs/module/zfs/zio_checksum.c +++ b/sys/contrib/openzfs/module/zfs/zio_checksum.c @@ -523,8 +523,12 @@ zio_checksum_error_impl(spa_t *spa, const blkptr_t *bp, info->zbc_has_cksum =3D 1; } - if (!ZIO_CHECKSUM_EQUAL(actual_cksum, expected_cksum)) + if (!ZIO_CHECKSUM_EQUAL(actual_cksum, expected_cksum)) { + printf("bad sum report:\n"); + printf("expected: %lx %lx %lx %lx\n", expected_cksum.zc_word[0], expected_cksum.zc_word[1], expected_cksum.zc_word[2], expected_cksum.zc_word[3]); + printf("actual: %lx %lx %lx %lx\n", actual_cksum.zc_word[0], actual_cksum.zc_word[1], actual_cksum.zc_word[2], actual_cksum.zc_word[3]); return (SET_ERROR(ECKSUM)); + } return (0); } we may need to revert this from upstream: commit 4c5fec01a48acc184614ab8735e6954961990235 Author: Tino Reichardt Date: Wed Mar 1 09:40:28 2023 +0100 Add generic implementation handling and SHA2 impl --=20 You are receiving this mail because: You are the assignee for the bug.=