From owner-freebsd-bugs@FreeBSD.ORG Sat Aug 13 17:20:17 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 860831065768 for ; Sat, 13 Aug 2011 17:20:17 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id C75478FC13 for ; Sat, 13 Aug 2011 17:20:07 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p7DHK7XU021513 for ; Sat, 13 Aug 2011 17:20:07 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p7DHK7EM021512; Sat, 13 Aug 2011 17:20:07 GMT (envelope-from gnats) Resent-Date: Sat, 13 Aug 2011 17:20:07 GMT Resent-Message-Id: <201108131720.p7DHK7EM021512@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Garrett Cooper Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0C3D9106566C for ; Sat, 13 Aug 2011 17:10:18 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id F05A18FC1A for ; Sat, 13 Aug 2011 17:10:17 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p7DHAHjR085107 for ; Sat, 13 Aug 2011 17:10:17 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id p7DHAHSQ085106; Sat, 13 Aug 2011 17:10:17 GMT (envelope-from nobody) Message-Id: <201108131710.p7DHAHSQ085106@red.freebsd.org> Date: Sat, 13 Aug 2011 17:10:17 GMT From: Garrett Cooper To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: misc/159745: [patch] Fix improperly specified dependency list for secure/lib/libssh X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Aug 2011 17:20:18 -0000 >Number: 159745 >Category: misc >Synopsis: [patch] Fix improperly specified dependency list for secure/lib/libssh >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Aug 13 17:20:07 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Garrett Cooper >Release: 9-CURRENT >Organization: iXsystems >Environment: FreeBSD bayonetta.local 9.0-CURRENT FreeBSD 9.0-CURRENT #0 r223824M: Sun Jul 31 20:34:01 PDT 2011 gcooper@bayonetta.local:/usr/obj/usr/src/sys/BAYONETTA amd64 >Description: Running buildworld will fail if one invokes it like: make buildworld -DWITHOUT_GSSAPI -DWITH_KERBEROS The problem is that the dependency list in Makefile.inc1 requires both GSSAPI and KERBEROS to be hardwired to no -- otherwise the build will fail looking for a non-existent dependency. The attached patch describes what I mean, but might not be the correct solution. The correct solution might be to set WITHOUT_KERBEROS if WITHOUT_GSSAPI is set, because gssapi is a dependency of kerberos, and not the other way around. >How-To-Repeat: make buildworld -DWITHOUT_GSSAPI -DWITH_KERBEROS >Fix: Patch attached with submission follows: Index: Makefile.inc1 =================================================================== --- Makefile.inc1 (revision 224801) +++ Makefile.inc1 (working copy) @@ -1257,8 +1257,9 @@ lib/libradius__L secure/lib/libssl__L: secure/lib/libcrypto__L .if ${MK_OPENSSH} != "no" _secure_lib_libssh= secure/lib/libssh +.if ${MK_GSSAPI} == "no" || ${MK_KERBEROS_SUPPORT} == "no" secure/lib/libssh__L: lib/libz__L secure/lib/libcrypto__L lib/libcrypt__L -.if ${MK_KERBEROS_SUPPORT} != "no" +.else secure/lib/libssh__L: lib/libgssapi__L kerberos5/lib/libkrb5__L \ kerberos5/lib/libhx509__L kerberos5/lib/libasn1__L lib/libcom_err__L \ lib/libmd__L kerberos5/lib/libroken__L >Release-Note: >Audit-Trail: >Unformatted: