From owner-svn-src-head@freebsd.org Fri Sep 11 14:20:26 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 57D923DC114; Fri, 11 Sep 2020 14:20:26 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BnyZy1h5pz4PgX; Fri, 11 Sep 2020 14:20:26 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:13b:39f::9f:25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 0303924CAB; Fri, 11 Sep 2020 14:20:26 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id F0D0F8D4A21C; Fri, 11 Sep 2020 14:20:24 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 7C3F1E707D9; Fri, 11 Sep 2020 14:20:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id XOabU2wzLfne; Fri, 11 Sep 2020 14:20:23 +0000 (UTC) Received: from [127.0.0.1] (unknown [IPv6:fde9:577b:c1a9:4902:2585:28cd:7660:77ea]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id E7468E707D8; Fri, 11 Sep 2020 14:20:22 +0000 (UTC) From: "Bjoern A. Zeeb" To: "Tomoaki AOKI" Cc: freebsd-current@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r365419 - in head/sys/dev: ath bwi iwm iwn mwl otus usb/wlan wtap Date: Fri, 11 Sep 2020 14:20:22 +0000 X-Mailer: MailMate (2.0BETAr6151) Message-ID: In-Reply-To: <20200911230248.d520bf8a1f3397be5d0f26c3@dec.sakura.ne.jp> References: <20200910074135.45d5b208b083c93efbce9259@dec.sakura.ne.jp> <178A8155-90E0-4B3E-BBCB-D3C7CA4C62B2@FreeBSD.org> <20200911230248.d520bf8a1f3397be5d0f26c3@dec.sakura.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Sep 2020 14:20:26 -0000 On 11 Sep 2020, at 14:02, Tomoaki AOKI wrote: > On Thu, 10 Sep 2020 10:22:05 +0000 > "Bjoern A. Zeeb" wrote: > >> On 9 Sep 2020, at 22:41, Tomoaki AOKI wrote: >> >>> This breaks at least iwm. (Other drivers not tested.) >>> >>> Messages below are repeatedly shown and no carrier detected. >>> Manually reverting this commit fixes the issue. >>> >>> iwm0: failed to send antennas before calibration: 35 >>> iwm_run_init_ucode: failed 35 >>> iwm_init_hw failed 35 >>> iwm0: could not initiate scan >>> >>> >>> and lesser times messages below. >>> >>> iwm0: iwm_send_phy_db_data: Cannot send HCMD of Phy DB cfg section, >>> 35 >>> iwm_init_hw failed 35 >>> iwm0: could not initiate scan >>> >> >> >> I’ll try to test iwm as well, in case you are faster, can you >> please >> try this instead of reverting; the previous version never made it >> past >> the first return anymore in the last years it seems, so we can remove >> the function entirely to keep the status quo: >> >> Sorry for the oversight. > > Your patch (needed to fix some line wrapping, though) fixed the issue > for me. Thanks! Committed in r365633 in HEAD. stable/12 already has the fix (#if 0ed the code). I’ll merged the change in 3 days to keep the code in sync. Thanks a lot for reporting and testing! Bjoern