From owner-freebsd-bugs@FreeBSD.ORG  Fri Nov 19 00:00:37 2010
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2F863106570B
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 19 Nov 2010 00:00:37 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 6F2808FC36
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 19 Nov 2010 00:00:34 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oAJ00Y1M084704
	for <freebsd-bugs@freefall.freebsd.org>; Fri, 19 Nov 2010 00:00:34 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oAJ00YWK084675;
	Fri, 19 Nov 2010 00:00:34 GMT (envelope-from gnats)
Date: Fri, 19 Nov 2010 00:00:34 GMT
Message-Id: <201011190000.oAJ00YWK084675@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Alexander Best <arundel@freebsd.org>
Cc: 
Subject: Re: bin/38727: [patch] mptable(1) should complain about garbage
	arguments
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Alexander Best <arundel@freebsd.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Nov 2010 00:00:37 -0000

The following reply was made to PR bin/38727; it has been noted by GNATS.

From: Alexander Best <arundel@freebsd.org>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: bin/38727: [patch] mptable(1) should complain about garbage arguments
Date: Thu, 18 Nov 2010 23:53:39 +0000

 --+QahgC5+KEYLbs62
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 here's an updated patch which applies cleanly to HEAD.
 
 cheers.
 alex
 
 -- 
 a13x
 
 --+QahgC5+KEYLbs62
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="mptable.c.diff"
 
 diff --git a/usr.sbin/mptable/mptable.c b/usr.sbin/mptable/mptable.c
 index a16a1b9..b461e61 100644
 --- a/usr.sbin/mptable/mptable.c
 +++ b/usr.sbin/mptable/mptable.c
 @@ -322,20 +322,21 @@ main( int argc, char *argv[] )
  	    if ( strcmp( optarg, "mesg") == 0 )
  	        dmesg = 1;
  	    else
 -	        dmesg = 0;
 -	    break;
 -	case 'h':
 -	    if ( strcmp( optarg, "elp") == 0 )
 -	        usage();
 +		usage();
  	    break;
  	case 'g':
  	    if ( strcmp( optarg, "rope") == 0 )
  	        grope = 1;
 +	    else
 +		usage();
  	    break;
  	case 'v':
  	    if ( strcmp( optarg, "erbose") == 0 )
  	        verbose = 1;
 +	    else
 +		usage();
  	    break;
 +	case 'h':
  	default:
  	    usage();
  	}
 
 --+QahgC5+KEYLbs62--