From owner-svn-src-head@freebsd.org Thu May 21 17:13:04 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9AF202DE636; Thu, 21 May 2020 17:13:04 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qt1-x844.google.com (mail-qt1-x844.google.com [IPv6:2607:f8b0:4864:20::844]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49SbmJ0fYmz42XW; Thu, 21 May 2020 17:13:03 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qt1-x844.google.com with SMTP id c24so6070648qtw.7; Thu, 21 May 2020 10:13:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=NBDsI+qr84dPVJLbT/b6zIwLekn5fluTJ4mnvqOwepw=; b=OW7zNKHsooh44N3rKVZRJaYPZxGMq/50Yo1+3j2X+mPSrH8SmdgSG/aZcnfhuUaUCY IYnwm9dQ18gQ7OgTIJF72K1eyh3nZMHs8D2r4FSpOv0Aoye71UkfTwhx/rpdD/+ogDgC qaORkeG9AJq5tXim9ZLRhRVZesfR2Cxsp/ooRYrzuIhSFYpXfRLnHyCzTFOUBiRk5Gpq j7G0eBgj6t/WjL3hiBpVmOOiS2MMbsiJNE0hyP7iOYbrfv3wT741D++f9wsHaHO5zBAZ acXmiQsWtmfeI8kPy+QVWunsRlvtmNP4npOrwRzAjdZjS3h1LISiuRMN2r33vI93dcTH 9ZAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=NBDsI+qr84dPVJLbT/b6zIwLekn5fluTJ4mnvqOwepw=; b=l/+Hs1USWyDhA3K6e0iWxaV9DV7OfwkcP10UGaAKi3M24JiQMFd+wKljYK86chLeKK d7zwES/YXaawNw7XWa2Y5Yiq9urSWMVE6r40325qrUFaAe3Lwgsmbi2OheLMKbCunPHC 5lgnpR6nXlnOo/MSlvGPGOf3eRw8WxSwrkoSgG41PKJbbon52T9E/05hnLqz5g4GcypF y1EsLy+WKKfBkhGXLErQ6g4fPzFfguCwzUBOPsnZ/Nvcd+05/w39PSgDOdR9JiwM+bb4 91scKAwmXGehzVVhEBXzcXGFcyDjyIRZr6iM59g4Zf0FXKm8pYvPlEUeB5c2Z3r0MpHd 6ExQ== X-Gm-Message-State: AOAM5310/1MRiQcrLZP/3wdcZZ0FlTgl5WUg4/hbPXwX1nku9IE01ZQ/ BwlrI/kQRY+z4FOlGWn5AKI= X-Google-Smtp-Source: ABdhPJyL3OYlugIRsHfz2X/i1881xUg6UktuBT/BLufaSLNHHACNNEDx8QD6u7jt8gaKuuXNAY6ojQ== X-Received: by 2002:ac8:1621:: with SMTP id p30mr10171634qtj.321.1590081183420; Thu, 21 May 2020 10:13:03 -0700 (PDT) Received: from raichu (toroon0560w-lp130-15-184-144-87-103.dsl.bell.ca. [184.144.87.103]) by smtp.gmail.com with ESMTPSA id h15sm3744066qkh.18.2020.05.21.10.13.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2020 10:13:02 -0700 (PDT) Sender: Mark Johnston Date: Thu, 21 May 2020 13:13:00 -0400 From: Mark Johnston To: Konstantin Belousov Cc: John Baldwin , Antoine Brodin , src-committers , svn-src-all , svn-src-head@freebsd.org Subject: Re: svn commit: r361303 - in head: lib/libc/gen libexec/rtld-elf sys/sys Message-ID: <20200521171300.GG85681@raichu> References: <202005202208.04KM8QPA020707@repo.freebsd.org> <20200521134152.GE64045@kib.kiev.ua> <20200521151248.GA85681@raichu> <20200521165646.GF64045@kib.kiev.ua> <20200521170124.GE85681@raichu> <20200521170958.GG64045@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200521170958.GG64045@kib.kiev.ua> X-Rspamd-Queue-Id: 49SbmJ0fYmz42XW X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=OW7zNKHs; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::844 as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [-1.42 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-0.69)[-0.693]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; NEURAL_HAM_LONG(-0.50)[-0.504]; MIME_GOOD(-0.10)[text/plain]; MID_RHS_NOT_FQDN(0.50)[]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; NEURAL_HAM_SHORT(-0.52)[-0.521]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::844:from]; FREEMAIL_TO(0.00)[gmail.com]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; RECEIVED_SPAMHAUS_PBL(0.00)[184.144.87.103:received]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 May 2020 17:13:04 -0000 On Thu, May 21, 2020 at 08:09:58PM +0300, Konstantin Belousov wrote: > On Thu, May 21, 2020 at 01:01:24PM -0400, Mark Johnston wrote: > > On Thu, May 21, 2020 at 07:56:46PM +0300, Konstantin Belousov wrote: > > > On Thu, May 21, 2020 at 09:03:44AM -0700, John Baldwin wrote: > > > > On 5/21/20 8:12 AM, Mark Johnston wrote: > > > > > On Thu, May 21, 2020 at 04:41:52PM +0300, Konstantin Belousov wrote: > > > > >> On Thu, May 21, 2020 at 03:02:07PM +0200, Antoine Brodin wrote: > > > > >>> On Thu, May 21, 2020 at 12:08 AM Konstantin Belousov wrote: > > > > >>>> > > > > >>>> Author: kib > > > > >>>> Date: Wed May 20 22:08:26 2020 > > > > >>>> New Revision: 361303 > > > > >>>> URL: https://svnweb.freebsd.org/changeset/base/361303 > > > > >>>> > > > > >>>> Log: > > > > >>>> Change the samantic of struct link_map l_addr member. > > > > >>>> > > > > >>>> It previously returned the object map base address, while all other > > > > >>>> ELF operating systems return load offset, i.e. the difference between > > > > >>>> map base and the link base. > > > > >>>> > > > > >>>> Explain the meaning of the field in the man page. > > > > >>>> > > > > >>>> Stop filling the mips-only l_offs member, which is apparently unused. > > > > >>>> > > > > >>>> PR: 246561 > > > > >>>> Requested by: Damjan Jovanovic > > > > >>>> Reviewed by: emaste, jhb, cem (previous version) > > > > >>>> Sponsored by: The FreeBSD Foundation > > > > >>>> MFC after: 1 week > > > > >>>> Differential revision: https://reviews.freebsd.org/D24918 > > > > >>>> > > > > >>>> Modified: > > > > >>>> head/lib/libc/gen/dlinfo.3 > > > > >>>> head/libexec/rtld-elf/rtld.c > > > > >>>> head/sys/sys/link_elf.h > > > > >>> > > > > >>> Hi, > > > > >>> > > > > >>> After this commit, some ports fail to build with signal 11. > > > > >>> For instance lang/perl5.30 fails to build with default options (DTRACE on) > > > > >>> Disabling the DTRACE option makes it able to build again. > > > > >>> > > > > >> I see, thank you for reporting. > > > > >> > > > > >> So drti.c:dtrace_dof_init() does read l_addr, and the dtrace code assumes > > > > >> that l_addr is the base, not relocbase. > > > > >> > > > > >> Mark, was dofhp_addr initialization changed comparing to Solaris ? > > > > > > > > > > It appears it has been the same since DTrace was imported. illumos > > > > > still has similar code. > > > > > > > > > > Note that drti.o is linked into any executable and shlib that defines > > > > > static probes, so the ABI change affects more than just dtrace(1). > > > > > Would it be possible to define a new value for RTLD_DI_LINKMAP, and > > > > > preserve the old behaviour for the old value? > > > > > > > > I think a bigger question is if Solaris/illumos treat l_addr as mapbase > > > > (absolute address) or relocbase (relative address). In the discussion > > > > in the phabricator I had assumed that all other OS's treated l_addr as > > > > the relative offset (relocbase). Does the code for illumos assume an > > > > absolute address or does it assume a relative address in l_addr? > > > > > > It is rather clear, since the dtrace code was pristine, that Solaris > > > provides the mapbase. I do not have Solaris/Illumos box anymore > > > (for quite some time), so I cannot check directly. > > > > > > My current PoV is that l_addr semantic must be restored, and relocbase > > > provided by newly added member. > > > > > > BTW, it is strange that perl triggers it, is it linked as PIE on HEAD ? > > > > Isn't the problem when perl is *not* linked as PIE? In this case > > relocbase is 0, so the ELF header access becomes a NULL pointer > > dereference. > drti checks for ET_DYN, only then it uses l_addr at all. The problem is before that, where it treats l_addr as a pointer to the ELF header so it can check the type. > PIE binaries are dso with non-zero base, non-PIE binaries are ET_EXEC, > which should make dtri.c ignore the l_addr value.