From owner-svn-src-head@freebsd.org  Tue Oct 23 17:53:36 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5225AFEE10B;
 Tue, 23 Oct 2018 17:53:36 +0000 (UTC) (envelope-from kib@FreeBSD.org)
Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org
 [IPv6:2610:1c1:1:606c::19:3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "mxrelay.nyi.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 0130D88829;
 Tue, 23 Oct 2018 17:53:36 +0000 (UTC) (envelope-from kib@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id EEBF0134BA;
 Tue, 23 Oct 2018 17:53:35 +0000 (UTC) (envelope-from kib@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id w9NHrZRH067857;
 Tue, 23 Oct 2018 17:53:35 GMT (envelope-from kib@FreeBSD.org)
Received: (from kib@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id w9NHrZht067856;
 Tue, 23 Oct 2018 17:53:35 GMT (envelope-from kib@FreeBSD.org)
Message-Id: <201810231753.w9NHrZht067856@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: kib set sender to kib@FreeBSD.org
 using -f
From: Konstantin Belousov <kib@FreeBSD.org>
Date: Tue, 23 Oct 2018 17:53:35 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r339663 - head/sys/dev/nvdimm
X-SVN-Group: head
X-SVN-Commit-Author: kib
X-SVN-Commit-Paths: head/sys/dev/nvdimm
X-SVN-Commit-Revision: 339663
X-SVN-Commit-Repository: base
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Oct 2018 17:53:36 -0000

Author: kib
Date: Tue Oct 23 17:53:35 2018
New Revision: 339663
URL: https://svnweb.freebsd.org/changeset/base/339663

Log:
  Initializer error variable in nvdimm_spa_uio().
  
  Several code paths might result in returning uninitialized value.
  
  Reported by:	coverity through cem
  CID:	1396315
  Sponsored by:	The FreeBSD Foundation

Modified:
  head/sys/dev/nvdimm/nvdimm_spa.c

Modified: head/sys/dev/nvdimm/nvdimm_spa.c
==============================================================================
--- head/sys/dev/nvdimm/nvdimm_spa.c	Tue Oct 23 17:06:36 2018	(r339662)
+++ head/sys/dev/nvdimm/nvdimm_spa.c	Tue Oct 23 17:53:35 2018	(r339663)
@@ -157,6 +157,7 @@ nvdimm_spa_uio(struct SPA_mapping *spa, struct uio *ui
 	vm_memattr_t mattr;
 	int error, n;
 
+	error = 0;
 	if (spa->spa_kva == NULL) {
 		mattr = nvdimm_spa_memattr(spa);
 		vm_page_initfake(&m, 0, mattr);