From owner-freebsd-current@freebsd.org Sun Dec 29 23:42:49 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1BC711EE6D0 for ; Sun, 29 Dec 2019 23:42:49 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-TO1-obe.outbound.protection.outlook.com (mail-eopbgr670043.outbound.protection.outlook.com [40.107.67.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47mHDR6qLDz4Grh for ; Sun, 29 Dec 2019 23:42:47 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YxPSyAenuF/7P/fnHUv/9V6v7YdFR68lB7RuodFlIphWkovUGhqIyUXm9NZMrUpnWDAXKHmhp2VeEJyigU7xoXYeEHhCZPA4xDTvEa8zd6B9BDwgNPe4ZOu6xJ4pJZYD+mNpSG6QytZVYYYTceovLPuY7RmFKdd/uPVYJLjRT5njJ9xBe9RLIUDv+fjUj9CV5qf+ZO16twod2F66r3yoZ4Gm9my/3qN3fhS8Tf9/CehkTkkUaiDGkv0A6sWGlLSE6C8Nqpp9CR3ctAwMQNwx9Y/78aj5IFk4BvsoZFbAlYfh7FfSLX8vZiex19/0QiDKnMBLlo7e9+jbXedgWgfTIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5ECfv9/sdxh2X1Ff6n71JCL2a1F/4BLHf/nLfqp7Sqg=; b=hKmtjAWgnVli6zZZ/dKu4L+MY5H8nQpPwGjfI+G5TyZ8ubO4x7tFvbNFrjUSPYGkg6xBf6Pq4hMTayBR+JcOxYKsUGoMgpSp3QwP3N38CHXTXTX5wSDAn0Iv089KuNLyMwmwgo9/nfl35ZhVCO9h0HrNgOC0LxVjyN9s0Nc9p53B/MYVcSQGCOY3gcVs2KqaIV2xZGQRnRg4fcZNadIVA/ExgFpnJQ4bUqxbwsJWXVZo/6SvOPlNVJa7znY1RAmHx31Nw6nhLykccTWgJYdDsx91pci9D6Z92PseTy+tt+ZDf9IUYkAf6DFLISrnIprrM6joemyQQJfQo0BN8vaa8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=uoguelph.ca; dmarc=pass action=none header.from=uoguelph.ca; dkim=pass header.d=uoguelph.ca; arc=none Received: from YQBPR0101MB1427.CANPRD01.PROD.OUTLOOK.COM (52.132.69.153) by YQBPR0101MB1860.CANPRD01.PROD.OUTLOOK.COM (52.132.67.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2581.11; Sun, 29 Dec 2019 23:42:46 +0000 Received: from YQBPR0101MB1427.CANPRD01.PROD.OUTLOOK.COM ([fe80::7512:8580:8d82:6c94]) by YQBPR0101MB1427.CANPRD01.PROD.OUTLOOK.COM ([fe80::7512:8580:8d82:6c94%6]) with mapi id 15.20.2581.007; Sun, 29 Dec 2019 23:42:46 +0000 From: Rick Macklem To: Dennis Clarke , "freebsd-current@freebsd.org" Subject: Re: getting rid of sys/nfs/nfs_lock.c Thread-Topic: getting rid of sys/nfs/nfs_lock.c Thread-Index: AQHVvd4uYot+uGDYskWjg23o3Tr07KfQqpKAgAEbkU8= Date: Sun, 29 Dec 2019 23:42:46 +0000 Message-ID: References: , <663f9bf2-c556-109f-dfdb-5eeb00fc0c2e@blastwave.org> In-Reply-To: <663f9bf2-c556-109f-dfdb-5eeb00fc0c2e@blastwave.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8b0b2473-1541-4946-cf1c-08d78cb8ce71 x-ms-traffictypediagnostic: YQBPR0101MB1860: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0266491E90 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(346002)(376002)(39860400002)(396003)(366004)(199004)(189003)(33656002)(76116006)(2906002)(316002)(110136005)(786003)(86362001)(7696005)(66446008)(64756008)(66556008)(6506007)(66946007)(186003)(52536014)(66476007)(71200400001)(81156014)(9686003)(8676002)(966005)(478600001)(55016002)(5660300002)(81166006)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:YQBPR0101MB1860; H:YQBPR0101MB1427.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: olMCXVTcZ6ya/r5dXsCzhcO2L1V/DwClrOhlpLWaR2/t4SSOQOWj14EchCZ5THr8RR4D+QkTq9faUm6pMm59UEA7tnPLRn2AMPT3LUcuAZZMcjurvbRCCujEV5pWMx9BgIbZ/n6vZgauv4pthLo64eKr96oFD9hEVSh8/ZhpzjLGCL8pjil//IUec8IoVHDB8MEf1VRpirqFTO68Z4E9e+UbHFQ6cXaFV7YuyuGfOu1kp7Cb8lBeLy17bVLLthvLpgtpDC5CxqLRkDS8NOW728Y+mNlGgvDmk+4AlEgSuTiUoZlGFp3Xb4955WVgSgNN3WiGmwYrPoXIXrZC+ueEeEvx44TufzfFePRxR1Q9dGjMDG9ILn5MpRiD5RoN1ICjVnSS8YvX1UN5YaJEioEFYPraSFlGbHcm9Rzh9iRrEVrI7V/BfPYdwO6H6TYqHj4WlDoXUBasczLU5bml3LxN8/plxgjYRak1fMiaW3MivfM= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 8b0b2473-1541-4946-cf1c-08d78cb8ce71 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Dec 2019 23:42:46.1091 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cbO/jhDcCYCwOh6vrZdgeRo0o8YL4COXEuIWk4VHmWWr6HLapO6hpPtQ4wXjSqBKCIAKv4ssXibI0n94FEBJvg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB1860 X-Rspamd-Queue-Id: 47mHDR6qLDz4Grh X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of rmacklem@uoguelph.ca designates 40.107.67.43 as permitted sender) smtp.mailfrom=rmacklem@uoguelph.ca X-Spamd-Result: default: False [-4.67 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[uoguelph.ca]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[43.67.107.40.list.dnswl.org : 127.0.3.0]; IP_SCORE(-1.37)[ipnet: 40.64.0.0/10(-3.84), asn: 8075(-2.95), country: US(-0.05)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:8075, ipnet:40.64.0.0/10, country:US]; ARC_ALLOW(-1.00)[i=1] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Dec 2019 23:42:49 -0000 Dennis Clarke wrote:=0A= >On 12/28/19 7:30 PM, Rick Macklem wrote:=0A= >> Hi,=0A= >>=0A= >> sys/nfs/nfs_lock.c uses Giant. Since it has not been used by default sin= ce=0A= >> March 2008, I suspect it can be removed from head without any impact.=0A= >> Post March 2008, the only way this code could be executed is by both=0A= >> building a kernel without "options NFSLOCKD" and deleting nfslockd.ko=0A= >> from the kernel boot directory and then running rpc.lockd on the system.= =0A= >>=0A= >> I doubt anyone has been doing both of the above, but if you think it is= =0A= >> still useful, please speak up. (I have an untested patch that replaces G= iant=0A= >> with a regular mutex. I realized this code is not used when I trying to = test it.;-)=0A= >>=0A= >> Also, if it seems appropriate, I could commit a patch that makes it prin= t out=0A= >> "deprecated and going away before FreeBSD 13" message, but I doubt anyon= e=0A= >> will ever see it.=0A= >> Should I do such a message and wait a few months for the deletion?=0A= >=0A= >Such a message is a good idea.=0A= >=0A= >I am curious if there is any way in which we would see that message when= =0A= >creating an NFS share via ZFS set sharenfs=3D'foo' ?=0A= Only if your kernel was built without "options NFSLOCKD" and you do not=0A= have nfslockd.ko in your kernel boot directory.=0A= Highly unlikely for amd64, since neither of the above would be true unless= =0A= you created a custom kernel config and deleted nfslockd.ko from the kernel= =0A= boot directory you installed it in.=0A= =0A= It is slightly more likely to occur for an arm installation, since many of = those=0A= do not configure NFS into the kernel, if you did not have the modules in th= e=0A= boot directory and you then started rpc.lockd.=0A= =0A= rick=0A= =0A= =0A= --=0A= Dennis Clarke=0A= RISC-V/SPARC/PPC/ARM/CISC=0A= UNIX and Linux spoken=0A= GreyBeard and suspenders optional=0A= _______________________________________________=0A= freebsd-current@freebsd.org mailing list=0A= https://lists.freebsd.org/mailman/listinfo/freebsd-current=0A= To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"= =0A=