From owner-svn-src-all@FreeBSD.ORG  Wed May 30 04:08:30 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C8AAA106564A;
	Wed, 30 May 2012 04:08:30 +0000 (UTC)
	(envelope-from eadler@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id 785318FC16;
	Wed, 30 May 2012 04:08:30 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q4U48UBB025021;
	Wed, 30 May 2012 04:08:30 GMT (envelope-from eadler@svn.freebsd.org)
Received: (from eadler@localhost)
	by svn.freebsd.org (8.14.4/8.14.4/Submit) id q4U48UVJ025019;
	Wed, 30 May 2012 04:08:30 GMT (envelope-from eadler@svn.freebsd.org)
Message-Id: <201205300408.q4U48UVJ025019@svn.freebsd.org>
From: Eitan Adler <eadler@FreeBSD.org>
Date: Wed, 30 May 2012 04:08:30 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r236289 - head/usr.sbin/lpr/lpr
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 May 2012 04:08:30 -0000

Author: eadler
Date: Wed May 30 04:08:29 2012
New Revision: 236289
URL: http://svn.freebsd.org/changeset/base/236289

Log:
  Relax security permissions on '.seq' file creation - the strict,
  but odd permissions resulted in a security alert from 110.neggrpperm
  
  PR:		kern/165533
  Submitted by:	Anton Shterenlikht <mexas@bristol.ac.uk>
  Submitted by:	J B <jb.1234abcd@gmail.com>
  Approved by:	cperciva
  MFC after:	1 week

Modified:
  head/usr.sbin/lpr/lpr/lpr.c

Modified: head/usr.sbin/lpr/lpr/lpr.c
==============================================================================
--- head/usr.sbin/lpr/lpr/lpr.c	Wed May 30 04:06:38 2012	(r236288)
+++ head/usr.sbin/lpr/lpr/lpr.c	Wed May 30 04:08:29 2012	(r236289)
@@ -846,7 +846,7 @@ mktemps(const struct printer *pp)
 
 	(void) snprintf(buf, sizeof(buf), "%s/.seq", pp->spool_dir);
 	seteuid(euid);
-	if ((fd = open(buf, O_RDWR|O_CREAT, 0661)) < 0) {
+	if ((fd = open(buf, O_RDWR|O_CREAT, 0664)) < 0) {
 		printf("%s: cannot create %s\n", progname, buf);
 		exit(1);
 	}