From owner-freebsd-bugs@FreeBSD.ORG Tue Jun 21 16:00:28 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 889EE1065672 for ; Tue, 21 Jun 2011 16:00:28 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 647938FC18 for ; Tue, 21 Jun 2011 16:00:28 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p5LG0MAN042932 for ; Tue, 21 Jun 2011 16:00:22 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p5LG0MGT042931; Tue, 21 Jun 2011 16:00:22 GMT (envelope-from gnats) Resent-Date: Tue, 21 Jun 2011 16:00:22 GMT Resent-Message-Id: <201106211600.p5LG0MGT042931@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Brian Olsen Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B46831065675 for ; Tue, 21 Jun 2011 15:51:46 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id A40FF8FC1F for ; Tue, 21 Jun 2011 15:51:46 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p5LFpkvc097096 for ; Tue, 21 Jun 2011 15:51:46 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id p5LFpkQq097095; Tue, 21 Jun 2011 15:51:46 GMT (envelope-from nobody) Message-Id: <201106211551.p5LFpkQq097095@red.freebsd.org> Date: Tue, 21 Jun 2011 15:51:46 GMT From: Brian Olsen To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: conf/158127: [patch] remount_optional option in rc.initdiskless doesn't actually work X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2011 16:00:28 -0000 >Number: 158127 >Category: conf >Synopsis: [patch] remount_optional option in rc.initdiskless doesn't actually work >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Jun 21 16:00:22 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Brian Olsen >Release: 8.2 >Organization: >Environment: FreeBSD mail.vagtelhave.dk 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Tue Jun 21 07:23:33 CEST 2011 root@lacuna-dev.maven-group.org:/usr/obj/freakbsd.lacuna/usr/src/sys/GENERIC i386 >Description: When trying to use the remount_optional option on a nanobsd like build that was going to run from an iso image with an optional remount of /dev/ufs/cfg onto /conf/default/etc I discovered that it doesn't actually work. When remount_optional is present it will always print the error message "mount -o ro /dev/ufs/cfg /conf/default/etc failed: ignoring due to remount_optional" even when the mount succeeds. And when the mount fails it still drops into a shell. A simple fix to the problem is attached. >How-To-Repeat: >Fix: Patch attached with submission follows: --- /etc/rc.initdiskless 2011-02-18 02:52:09.000000000 +0100 +++ etc/rc.initdiskless 2011-06-21 17:15:21.000000000 +0200 @@ -166,14 +166,17 @@ chkerr() { lastitem () ( n=$(($# - 1)) ; shift $n ; echo $1 ) mountpoint="$(lastitem $2)" - [ -r $mountpoint/remount_optional ] && ( echo "$2 failed: ignoring due to remount_optional" ; return ) case $1 in 0) ;; *) - echo "$2 failed: dropping into /bin/sh" - /bin/sh - # RESUME + if [ -r $mountpoint/remount_optional ] ; then + echo "$2 failed: ignoring due to remount_optional" + else + echo "$2 failed: dropping into /bin/sh" + /bin/sh + # RESUME + fi ;; esac } >Release-Note: >Audit-Trail: >Unformatted: