Date: Thu, 11 Apr 2013 17:59:24 +1000 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Gleb Smirnoff <glebius@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r249355 - head/lib/libkvm Message-ID: <20130411175308.Q1435@besplex.bde.org> In-Reply-To: <201304110730.r3B7Uo6d067302@svn.freebsd.org> References: <201304110730.r3B7Uo6d067302@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> Log: > Include types.h for C99 uintXX_t types. This adds namespace pollution that was carefully left out. > Modified: > head/lib/libkvm/kvm.h > > Modified: head/lib/libkvm/kvm.h > ============================================================================== > --- head/lib/libkvm/kvm.h Thu Apr 11 07:02:27 2013 (r249354) > +++ head/lib/libkvm/kvm.h Thu Apr 11 07:30:49 2013 (r249355) > @@ -34,7 +34,7 @@ > #define _KVM_H_ > > #include <sys/cdefs.h> > -#include <sys/_types.h> The __uintXX_t types are declared here, and should be used, like the __Xsize_t types already are. > +#include <sys/types.h> > #include <nlist.h> > > /* Default version symbol. */ > Hmm, I never got around to committing the cleaning of <nlist.h>. It only takes 1 forward declaration and perhaps fixing clients that depend on the pollution. % Index: kvm.h % =================================================================== % RCS file: /home/ncvs/src/lib/libkvm/kvm.h,v % retrieving revision 1.16 % diff -u -2 -r1.16 kvm.h % --- kvm.h 13 Oct 2003 04:44:55 -0000 1.16 % +++ kvm.h 13 Oct 2003 04:46:29 -0000 % @@ -40,5 +40,4 @@ % #include <sys/cdefs.h> % #include <sys/_types.h> % -#include <nlist.h> % % /* Default version symbol. */ % @@ -59,4 +58,5 @@ % % struct kinfo_proc; % +struct nlist; % struct proc; % Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130411175308.Q1435>