Date: Mon, 13 Sep 2010 20:55:45 +0400 From: Pavel I Volkov <pol@opk.ru> To: Norikatsu Shigemura <nork@FreeBSD.org> Cc: "ports@FreeBSD.org" <ports@FreeBSD.org> Subject: Re: [ports/databases/sqlite3] Fix build error WITH_ICU Message-ID: <4C8E5791.3040201@opk.ru> In-Reply-To: <20100912005658.628b27b0.nork@FreeBSD.org> References: <20100912005658.628b27b0.nork@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello
Unfortunately I was unable to repeat the mistake you might have.
However, your proposed path specifies the correct sequence of the
inclusion of header files in the event of conflict with already
installed version.
I agree with your proposal.
Thank you.
11.09.2010 19:56, Norikatsu Shigemura wrote:
> Hi pol.
>
> sqlite3 has a build issue WITH_ICU like following:
> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
> ./src/shell.c: In function 'display_stats':
> ./src/shell.c:982: error: 'SQLITE_STATUS_MALLOC_COUNT' undeclared (first use in this function)
> ./src/shell.c:982: error: (Each undeclared identifier is reported only once
> ./src/shell.c:982: error: for each function it appears in.)
> :
> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
>
> Because -I/usr/local/include is too fast than -I. -I./src.
> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
> libtool: link: cc -I/usr/local/include -O2 -pipe -march=nocona -DSQLITE_SOUNDEX=1 -DSQLITE_SECURE_DELETE=1 -fno-strict-aliasing -DSQLITE_OS_UNIX=1 -I. -I./src ...
> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
> So sqlite3's sources includes already installed sqlite3.h.
>
> To fix this issue, I made a patch. May I commit this OK?
> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
> --- Makefile.orig 2010-09-03 18:27:26.052085000 +0900
> +++ Makefile 2010-09-12 00:45:41.812111163 +0900
> @@ -149,8 +149,8 @@
> CONFIGURE_ARGS+= --disable-load-extension
> .endif
>
> -CONFIGURE_ENV+= CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
> -MAKE_ENV+= CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
> +CONFIGURE_ENV+= CPPFLAGS="-I. -I./src ${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
> +MAKE_ENV+= CPPFLAGS="-I. -I./src ${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
>
> post-install:
> .if defined(WITH_TCLWRAPPER)
> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
>
> Thank you.
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C8E5791.3040201>