From owner-svn-src-head@freebsd.org Fri Sep 18 20:33:52 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5E9C79CF110; Fri, 18 Sep 2015 20:33:52 +0000 (UTC) (envelope-from davide.italiano@gmail.com) Received: from mail-yk0-x235.google.com (mail-yk0-x235.google.com [IPv6:2607:f8b0:4002:c07::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1F4571DDD; Fri, 18 Sep 2015 20:33:52 +0000 (UTC) (envelope-from davide.italiano@gmail.com) Received: by ykdu9 with SMTP id u9so57291819ykd.2; Fri, 18 Sep 2015 13:33:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=Y6WrCiVZ2STFpwL5Wt0nzVv9jMUkXnTDGzDHJnyOfiI=; b=JeN4/wUj6HfTL+YcTmS8T1lYCi09wfZdXxBwoHOX1MFj2fwEhhMlTVD5oRji9WvcUB BspkwB/36bRBmKsKSmQ/BOmL5LJ2e+InlBYLLw9/BPuPnUL2muCMVXpIm66Zfo21qD7M J9wrHj104RYJefV24IubhIRmVFWF2iEnJJVuz0Cw3MEpQ6FcvW/GOSJXcLQ2NFP+pR3L G1sja5bh8GDrAmH6vGcM80+ak0uDKolGKVa3UqMd9Ly2PPxu//HgrCtPM4rReQdPzt2D EK+mVGPTwiaL0PLf1Hsxo2gcLAe5rc/L8FALWsgNvGWfz7mzGpFqD6b4NnlnNGaaFYqG 1eSg== X-Received: by 10.129.84.132 with SMTP id i126mr6665425ywb.96.1442608431136; Fri, 18 Sep 2015 13:33:51 -0700 (PDT) MIME-Version: 1.0 Sender: davide.italiano@gmail.com Received: by 10.37.17.134 with HTTP; Fri, 18 Sep 2015 13:33:11 -0700 (PDT) In-Reply-To: <55FA69BD.10507@selasky.org> References: <201509141052.t8EAqRWf008293@repo.freebsd.org> <20150916220559.GS1023@FreeBSD.org> <55FA69BD.10507@selasky.org> From: Davide Italiano Date: Fri, 18 Sep 2015 13:33:11 -0700 X-Google-Sender-Auth: -9JHCQJZSd-y9JIROMBsqRSOSn0 Message-ID: Subject: Re: svn commit: r287780 - in head: share/man/man9 sys/kern sys/sys To: Hans Petter Selasky Cc: Gleb Smirnoff , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Sep 2015 20:33:52 -0000 On Thu, Sep 17, 2015 at 12:20 AM, Hans Petter Selasky wrote: > On 09/17/15 00:05, Gleb Smirnoff wrote: >> >> Weren't you explicitly asked not to touch this system without a proper >> review and discussion? > > > Adding a new function is not touching code. > > --HPS > I tried to stay away from this conversation as much as I could, partly because I haven't touched this code in a couple of years, partly because others have already expressed concerns. Sorry if I sound a little bit harsh here but this is not your playground. As somebody who spent a lot of time working on callout in the past I'm completely opposed to introducing new KPI without proper review. This has several problems: 1) It's a dead KPI, i.e. it has no consumers, which is a fairly bad engineering practice. 2) Your commit message didn't explain what (if any) is the use case for this. 3) You didn't discuss it with anybody else. Review timeout is not an excuse. If you want somebody to review this code ping -current or in the worst case developers@. Writing interfaces is hard, most of the times when you introduce a new one you may miss something useful, that's why we have reviews. It happened in the past when me and mav@ introduced the new callout precision API and we had to change all the functions in the middle of development because of external feedback. Not even talking about the possibility of us changing our mind and removing this KPI after 11 is shipped, while third-party vendors started using it and very unhappily have to #ifdef their drivers, or even worse drop FreeBSD support. tl;dr: I personally don't think that your past/records have some influence on this. You introduced a new KPI, you took this decision lightly, and completely ignored complaints from others. This is a very bad attitude problem, and that's so much worse than all the technical problems this commit brings. -- Davide "There are no solved problems; there are only problems that are more or less solved" -- Henri Poincare