From owner-cvs-all Sun Apr 8 16:25:16 2001 Delivered-To: cvs-all@freebsd.org Received: from Awfulhak.org (awfulhak.demon.co.uk [194.222.196.252]) by hub.freebsd.org (Postfix) with ESMTP id C0DE737B422; Sun, 8 Apr 2001 16:25:09 -0700 (PDT) (envelope-from brian@Awfulhak.org) Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [172.16.0.12]) by Awfulhak.org (8.11.3/8.11.3) with ESMTP id f38NPNU74183; Mon, 9 Apr 2001 00:25:23 +0100 (BST) (envelope-from brian@lan.Awfulhak.org) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.11.3/8.11.3) with ESMTP id f38NOpl11450; Mon, 9 Apr 2001 00:24:51 +0100 (BST) (envelope-from brian@hak.lan.Awfulhak.org) Message-Id: <200104082324.f38NOpl11450@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.3.1 01/18/2001 with nmh-1.0.4 To: Dima Dorfman Cc: Brian Somers , mckusick@FreeBSD.org, Bruce Evans , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, brian@Awfulhak.org Subject: Re: cvs commit: src/bin/ps ps.c In-Reply-To: Message from Dima Dorfman of "Sun, 08 Apr 2001 15:48:26 PDT." <20010408224827.EC04A3E09@bazooka.unixfreak.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 09 Apr 2001 00:24:51 +0100 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > Brian Somers writes: > > > So, the question is: do we want a `sess' column? > > > > Personally I preferred it *with* the sess column (my change just > > removed an irritating error message - I use ``ps j'' all the time and > > have eventually gotten sick of seeing it). Kirk, do you have any > > objections to restoring sess ? > > Well, to [hopefully] make it easier for everyone, I've produced two patches: > > http://www.unixfreak.org/~dima/home/ps-sess.diff > http://www.unixfreak.org/~dima/home/ps-tsess.diff > > The first one adds a ki_sess pointer to kinfo_proc. The second one > adds ki_sess *and* ki_tsess pointers. They represent the session > pointer and the tty session pointer, respectivley. > > Anyone have any objections to these? If not, anyone feel like > commiting them? I Certainly don't. On a side note, the KINFO_PROC_SIZE looks rather strange. I assume this is there to ensure that sizes stay the same and that it's not supposed to work with odd ``long'' sizes ? I'll test & commit in a couple of days if nobody complains. > Thanks, > > Dima Dorfman > dima@unixfreak.org -- Brian Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message