From owner-svn-src-head@freebsd.org Fri Feb 9 19:04:51 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 03D69F1BF7F; Fri, 9 Feb 2018 19:04:51 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A37987367F; Fri, 9 Feb 2018 19:04:50 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 9CB155CAC; Fri, 9 Feb 2018 19:04:50 +0000 (UTC) Date: Fri, 9 Feb 2018 19:04:50 +0000 From: Alexey Dokuchaev To: Warner Losh Cc: John Baldwin , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers , Warner Losh Subject: Re: svn commit: r329064 - head/share/zoneinfo Message-ID: <20180209190450.GA85711@FreeBSD.org> References: <201802091550.w19FoXEb018181@repo.freebsd.org> <14002093.zLdzgIqnsv@ralph.baldwin.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2018 19:04:51 -0000 On Fri, Feb 09, 2018 at 11:50:35AM -0700, Warner Losh wrote: > On Fri, Feb 9, 2018 at 10:49 AM, John Baldwin wrote: > > On Friday, February 09, 2018 03:50:33 PM Warner Losh wrote: > > > New Revision: 329064 > > > URL: https://svnweb.freebsd.org/changeset/base/329064 > > > > > > Log: > > > We don't actually need env here, so drop it. All shells allow setting > > > of shell variables for the next command like this. > > > > Eh: > > > > % LC_ALL=C env > > LC_ALL=C: Command not found. > > > > csh and tcsh don't let you set environment variables as a prefix. > > > > That said, if you try to use csh as the SHELL for make I bet many things > > would break. > > Right, all shells supported as SHELL for make. csh isn't on the list of > supported shells. Your bet is right: a lot of things do break. I don't really understand why we're discussing it: (t)csh, fish, whatever are for interactive use *only*. Scripts (and makefiles) should only be written for standard plain POSIX shell. ./danfe