Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 16 Dec 2012 18:43:48 +0400 (MSK)
From:      Maxim Samsonov <xors@mailup.net>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/174482: [PATCH]: x11/slim Fix PAM error handling
Message-ID:  <201212161443.qBGEhmor001320@xors.pg.org>
Resent-Message-ID: <201212161450.qBGEo0qT055219@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         174482
>Category:       ports
>Synopsis:       [PATCH]: x11/slim Fix PAM error handling
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Dec 16 14:50:00 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Maxim Samsonov
>Release:        FreeBSD 8.3-STABLE i386
>Organization:
>Environment:
>Description:
Adds "Conversation failure" error code to authentication errors list in order to permit login with special usernames.
Also fixes console command.
>How-To-Repeat:
Try to login with special username like "exit" or "console" if slim was built with PAM support enabled.
>Fix:
--- x11_slim-pam.patch begins here ---
diff --git a/x11/slim/files/patch-PAM.cpp b/x11/slim/files/patch-PAM.cpp
new file mode 100644
--- /dev/null
+++ b/x11/slim/files/patch-PAM.cpp
@@ -0,0 +1,10 @@
+--- PAM.cpp.orig	2012-06-26 12:20:14.000000000 +0400
++++ PAM.cpp	2012-12-16 16:05:09.000000000 +0400
+@@ -128,6 +128,7 @@
+             case PAM_MAXTRIES:
+             case PAM_CRED_INSUFFICIENT:
+             case PAM_AUTH_ERR:
++            case PAM_CONV_ERR:
+                 throw Auth_Exception(pam_handle, "pam_authentication()", last_result);
+ 
+             case PAM_SUCCESS:
diff --git a/x11/slim/files/patch-slim.conf b/x11/slim/files/patch-slim.conf
--- a/x11/slim/files/patch-slim.conf
+++ b/x11/slim/files/patch-slim.conf
@@ -18,7 +18,7 @@
  reboot_cmd          /sbin/shutdown -r now
 -console_cmd         /usr/bin/xterm -C -fg white -bg black +sb -T "Console login" -e /bin/sh -c "/bin/cat /etc/issue; exec /bin/login"
 -#suspend_cmd        /usr/sbin/suspend
-+console_cmd         %%LOCALBASE%%/bin/xterm -C -fg white -bg black +sb -T "Console login" -e /bin/sh -c "/bin/cat /etc/motd; exec /bin/login"
++console_cmd         %%LOCALBASE%%/bin/xterm -C -fg white -bg black +sb -T "Console login" -e /bin/sh -c "/bin/cat /etc/motd; exec /usr/bin/login"
 +suspend_cmd        /usr/sbin/acpiconf -s 3
  
  # Full path to the xauth binary
--- x11_slim-pam.patch ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201212161443.qBGEhmor001320>