From owner-freebsd-current@freebsd.org Sat Sep 12 22:07:20 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9939B3E400A for ; Sat, 12 Sep 2020 22:07:20 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4BpmvD3ZcGz4YtL for ; Sat, 12 Sep 2020 22:07:20 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by mailman.nyi.freebsd.org (Postfix) id 78D703E4008; Sat, 12 Sep 2020 22:07:20 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 776A33E3D15; Sat, 12 Sep 2020 22:07:20 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BpmvD2GmKz4Yqx; Sat, 12 Sep 2020 22:07:20 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.codepro.be", Issuer "Let's Encrypt Authority X3" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 16DED138BE; Sat, 12 Sep 2020 22:07:20 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 8552043F5A; Sun, 13 Sep 2020 00:07:18 +0200 (CEST) From: "Kristof Provost" To: "Gleb Smirnoff" Cc: xtouqh@mm.st, current@freebsd.org, net@freebsd.org Subject: Re: bridge/igb panic: sleepq_add: td 0xfffffe01bbce5300 to sleep on wchan 0xffffffff8157d9a0 with sleeping prohibited Date: Sun, 13 Sep 2020 00:07:14 +0200 X-Mailer: MailMate (1.13.2r5673) Message-ID: <3891457F-A600-48C0-B9D1-C2259251FB42@FreeBSD.org> In-Reply-To: <20200911170601.GT1269@FreeBSD.org> References: <8172451b-81ea-aacb-02bd-b5005d18646d@mm.st> <20200911170601.GT1269@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Sep 2020 22:07:20 -0000 On 11 Sep 2020, at 19:06, Gleb Smirnoff wrote: > Kristof, > > can you please take a look? IMHO, the problem is that with r360345 > the bridge_ioctl() is fully covered by epoch. IMHO, should be either > more fine grained covered, or use internal locking, because some of > the code downstream (driver ioctl) may sleep. > How does https://reviews.freebsd.org/D26418 look? Best regards, Kristof