From owner-svn-src-head@freebsd.org Wed Aug 26 19:19:25 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 697703B92CE for ; Wed, 26 Aug 2020 19:19:25 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BcFzJ6436z4W0q for ; Wed, 26 Aug 2020 19:19:24 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wr1-f68.google.com with SMTP id f7so2980156wrw.1 for ; Wed, 26 Aug 2020 12:19:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=yDfpRmB3yHyU7x3XNaNjEyQwQkhsYlT4d03gzG2A10E=; b=ZzSVNVNeV+ifrkntBTUT6uoC+Ujrttcj5u60Asz+FUaINXEor5PIYF+ZTH0irM5wXz y0XpH+CAvA5p5I4v3FB6cbzN0qp3P90If/qa9P1PM0C7g9oo64CsKRaQFUJEbFJtbnaL imtdJ4pNGu40eArxz7ezS+CmQZYl/VIoeSOVRNM7ri5YiZwJwJGgalvLDqizB63h0NHp ptgLaQhS24l4YPBpn+bsaOLONiQYwVSdUqtsEVHBm9GbL+6ChCXEQIL5BRwS/HAnc9E4 HFslZb+MrC1GGVUxJexcnaV6/4fzEL+gX/zqN96uv2LaRU6KyBg3S0R5dC4M9adWWseL XWNw== X-Gm-Message-State: AOAM530Plva9QhEF8H/a6aAWuXxkOdt41wv677b9TVtkkCOg1j25mYeV AvTDaICuZSTaGa1EPBx3yGupeOXFY1/ydw== X-Google-Smtp-Source: ABdhPJznz2B+7Q29lEMmwYZLqxcIsOe7YkvXkWykaWVSU1o0z+bOjEoQmXTApcenxXunegdfVvBYoQ== X-Received: by 2002:a5d:684b:: with SMTP id o11mr17735355wrw.101.1598469563309; Wed, 26 Aug 2020 12:19:23 -0700 (PDT) Received: from [192.168.149.251] (trinity-students-nat.trin.cam.ac.uk. [131.111.193.104]) by smtp.gmail.com with ESMTPSA id g16sm8960067wrs.88.2020.08.26.12.19.22 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Aug 2020 12:19:22 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\)) Subject: Re: svn commit: r364799 - in head: share/man/man9 sys/crypto/ccp sys/dev/cxgbe/crypto sys/dev/sec sys/kern sys/opencrypto From: Jessica Clarke In-Reply-To: <7e0abc1a-a397-46c3-b283-2c1ab21a9c4d@www.fastmail.com> Date: Wed, 26 Aug 2020 20:19:21 +0100 Cc: Alan Somers , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <2534D2E5-2974-4067-8B9C-53EE3E8C6A68@freebsd.org> References: <202008260237.07Q2bhwF045988@repo.freebsd.org> <7e0abc1a-a397-46c3-b283-2c1ab21a9c4d@www.fastmail.com> To: Brandon Bergren X-Mailer: Apple Mail (2.3608.120.23.2.1) X-Rspamd-Queue-Id: 4BcFzJ6436z4W0q X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 209.85.221.68 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com X-Spamd-Result: default: False [-0.93 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; FREEMAIL_TO(0.00)[imap.cc]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; MID_RHS_MATCH_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.82)[-0.821]; FREEFALL_USER(0.00)[jrtc27]; FROM_HAS_DN(0.00)[]; NEURAL_SPAM_SHORT(0.26)[0.262]; NEURAL_HAM_LONG(-0.87)[-0.867]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.221.68:from]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.221.68:from]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[svn-src-head] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Aug 2020 19:19:25 -0000 On 26 Aug 2020, at 20:16, Brandon Bergren wrote: > On Tue, Aug 25, 2020, at 9:37 PM, Alan Somers wrote: >> Author: asomers >> Date: Wed Aug 26 02:37:42 2020 >> New Revision: 364799 >> URL: https://svnweb.freebsd.org/changeset/base/364799 >>=20 >> Modified: head/sys/dev/sec/sec.c >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/sys/dev/sec/sec.c Wed Aug 26 02:13:27 2020 = (r364798) >> +++ head/sys/dev/sec/sec.c Wed Aug 26 02:37:42 2020 = (r364799) >> @@ -851,6 +851,9 @@ sec_desc_map_dma(struct sec_softc *sc, struct = sec_dma_ >> case CRYPTO_BUF_MBUF: >> size =3D m_length(crp->crp_buf.cb_mbuf, NULL); >> break; >> + case CRYPTO_BUF_VMPAGE: >> + size =3D PAGE_SIZE - cb->cb_vm_page_offset; >> + break; >> default: >> return (EINVAL); >> } >=20 > Uh, where is cb coming from? Shouldn't this be using = crp->crp_buf.cb_vm_page_offset? This is causing a build failure on = powerpc and powerpcspe. I don't see why other platforms aren't also = erroring out here. Because it's PowerPC-specific: sys/conf/files.powerpc:dev/sec/sec.c optional sec mpc85xx Jess