From owner-dev-commits-src-main@freebsd.org Mon Mar 8 17:47:51 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 53029550D0E; Mon, 8 Mar 2021 17:47:51 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DvQm65v27z4vpq; Mon, 8 Mar 2021 17:47:50 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.229.168]) by shaw.ca with ESMTPA id JJyslxS0PeHr9JJytlrUFs; Mon, 08 Mar 2021 10:47:48 -0700 X-Authority-Analysis: v=2.4 cv=Yq/K+6UX c=1 sm=1 tr=0 ts=60466344 a=7AlCcx2GqMg+lh9P3BclKA==:117 a=7AlCcx2GqMg+lh9P3BclKA==:17 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=dESyimp9J3IA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=ZB5LerlCAAAA:8 a=pGLkceISAAAA:8 a=bBqXziUQAAAA:8 a=VxmjJ2MpAAAA:8 a=EkcXrb_YAAAA:8 a=kA6XjwGokMnRZUBWtCkA:9 a=CjuIK1q_8ugA:10 a=3x16XyzRRVwA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=YKPTzOroS2oaEK2QgPcx:22 a=BjKv_IHbNJvPKzgot4uq:22 a=7gXAzLPJhVmCkEl4_tsf:22 a=LK5xJRSDVpKd5WXXoEvA:22 a=BPzZvq435JnGatEyYwdK:22 Received: from slippy.cwsent.com (slippy [IPv6:fc00:1:1:1::5b]) by spqr.komquats.com (Postfix) with ESMTPS id F07592FCF; Mon, 8 Mar 2021 09:47:44 -0800 (PST) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.16.1/8.16.1) with ESMTP id 128HliPA008952; Mon, 8 Mar 2021 09:47:44 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <202103081747.128HliPA008952@slippy.cwsent.com> X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Stefan Esser cc: Cy Schubert , dev-commits-src-all@freebsd.org, src-committers@freebsd.org, dev-commits-src-main@freebsd.org, Chris Rees , Baptiste Daroussin , Rick Parrish , Alastair Hogge Subject: Re: git: 77e1ccbee3ed - main - rc: implement parallel boot In-reply-to: <4a4e021c-c874-5511-0e5a-4364df98e2c4@freebsd.org> References: <202102231027.11NARYYE041280@gitrepo.freebsd.org> <6D4FCE07-B996-430C-8EA8-6CB37A6DEEE8@bayofrum.net> <74fde23ead6719ac4e56dacb51bca6ed@bayofrum.net> <202103080716.1287GQWB055131@slippy.cwsent.com> <2ed29c1254d48c3724b944ba4a7d6f3c@riseup.net> <38e603a7-6c04-38f0-2ab8-84dc4303a4e6@freebsd.org> <202103081422.128EMmC9075829@slippy.cwsent.com> <4a4e021c-c874-5511-0e5a-4364df98e2c4@freebsd.org> Comments: In-reply-to Stefan Esser message dated "Mon, 08 Mar 2021 18:05:50 +0100." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 08 Mar 2021 09:47:44 -0800 X-CMAE-Envelope: MS4xfCHZ4J45VMNhdL8ZSCdaafCRuI8avLJKHlfxnSl5lf+I+nIBelqeVve9nL/zoPCaRhYwYHgcpan/V3fgmZ2+1z7Qf8EfJHNvMylhJwlQWJ1PNgOVDCEH 5HN6YXBv69lvrprEXDVKUikGiK99fYkosAdlcSci2d2i3r4WiAjIZFq3m++Zor8b5oXs3RyAWvCnzThuWd5p6fDsFPPoS6ZiFbMreOawyzprCNdiNEqmheln Zgo4XG57Mpb5VvA70DZK05W/mN24ReGiXFSQkRJMkRK5BH1bZBNgNYT5rJERPTE2pv7Yv0Gqbiu0GTVlTB8il0GhTw3dnXws0tLB7bjGAB9KvtpYmH+lcOZ6 /r02+rdTzhlWvko5NVvQJ7oIvJFd5/CioCGAQSRVkJL+wzqdmRyg8hnFzTs2DMDacE8UnIawylsyuBJQa4Ts3HILzHEsOg== X-Rspamd-Queue-Id: 4DvQm65v27z4vpq X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Mar 2021 17:47:51 -0000 In message <4a4e021c-c874-5511-0e5a-4364df98e2c4@freebsd.org>, Stefan Esser wri tes: > This is an OpenPGP/MIME signed message (RFC 4880 and 3156) > --NK2NXzwQu7dx8KsgmaoRg3Dm6O6zdPwBc > Content-Type: multipart/mixed; boundary="IvLrYgq138dlzrHKca2qNTCpIvtGaetXM"; > protected-headers="v1" > From: Stefan Esser > To: Cy Schubert > Cc: dev-commits-src-all@freebsd.org, src-committers@freebsd.org, > dev-commits-src-main@freebsd.org, Chris Rees , > Baptiste Daroussin , Rick Parrish , > Alastair Hogge > Message-ID: <4a4e021c-c874-5511-0e5a-4364df98e2c4@freebsd.org> > Subject: Re: git: 77e1ccbee3ed - main - rc: implement parallel boot > References: <202102231027.11NARYYE041280@gitrepo.freebsd.org> > <6D4FCE07-B996-430C-8EA8-6CB37A6DEEE8@bayofrum.net> > <74fde23ead6719ac4e56dacb51bca6ed@bayofrum.net> > <202103080716.1287GQWB055131@slippy.cwsent.com> > <2ed29c1254d48c3724b944ba4a7d6f3c@riseup.net> > <38e603a7-6c04-38f0-2ab8-84dc4303a4e6@freebsd.org> > <202103081422.128EMmC9075829@slippy.cwsent.com> > In-Reply-To: <202103081422.128EMmC9075829@slippy.cwsent.com> > > --IvLrYgq138dlzrHKca2qNTCpIvtGaetXM > Content-Type: text/plain; charset=windows-1252; format=flowed > Content-Language: en-US > Content-Transfer-Encoding: quoted-printable > > Am 08.03.21 um 15:22 schrieb Cy Schubert: > >> SDDM fails to successfully start an X session now, too. > >> > >> It repeatedly tries to start the X server without success. > >> Only a "service sddm restart" terminates this loop. > >> > >> I do assume that the same applies to quite a number of services > >> that are installed form ports/packages. > >> > >> While we can test parallel execution of rc scripts in base, this > >> is not easily possible for the large number of optional services > >> provided by ports/packages. > >> > >> I'll try to find the cause of the start-up failure for the SDDM > >> case on my system. But even if I get it fixed on my system, it > >> may still fail to start the X server on systems with a different > >> set of ports ... > >> > >> Regards, STefan > >=20 > > Is this new breakage after 763db589328 or before the fixes to this? > > This issue exists since the initial commit that enabled parallel start=20 > of rc scripts. I do not see why the X server does not start, since the > commands that are started in parallel appear to be completely unrelated > and I do assume that scripts are only started from the next line after > the previous ones are running (but maybe not yet completely functional). Yes, the original commit broke rc due to some incorrect assumptions by the author -- it messed up non-parallel boot here. I don't use parallel rc here. I think bapt@ does. > > SDDM is in the 2nd-last line of rcorder -p output on my system: > > /etc/rc.d/sendmail > /usr/local/etc/rc.d/apache24 > /usr/local/etc/rc.d/postfix > /etc/rc.d/othermta > /etc/rc.d/bgfsck > /usr/local/etc/rc.d/postgresql > /etc/rc.d/securelevel > /usr/local/etc/rc.d/sddm > > (All the above listed rc files are on a single line, actually.) When I started looking at it, it uses spaces to separate related scripts to be started serially and line feeds for parallel threads. > > > BTW: I was surprised to see the following line 139 in /etc/rc: > > files=`rcorder ${skip} ${skip_firstboot} /etc/rc.d/* ${local_rc} > ${_rc_parallel} 2>/dev/null` > > > Since ${_rc_parallel} is at the end of the command line, it does not > have any impact on the output that is generated ... > > This seems to indicate that scripts from /usr/local/etc/rc.d are not > executed in parallel, which makes the SDDM failure even more > surprising. I'll leave this to bapt@ and the author to answer. I suspect that this too wasn't tested, hence the suggestion that this not be MFCed for six weeks, or maybe never. The original commit seriously broke my infrastructure here. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org The need of the many outweighs the greed of the few.