From owner-freebsd-current@FreeBSD.ORG Fri Jun 6 19:50:37 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4687FF89; Fri, 6 Jun 2014 19:50:37 +0000 (UTC) Received: from mx1.stack.nl (relay04.stack.nl [IPv6:2001:610:1108:5010::107]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "mailhost.stack.nl", Issuer "CA Cert Signing Authority" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 0AB4E27D2; Fri, 6 Jun 2014 19:50:37 +0000 (UTC) Received: from snail.stack.nl (snail.stack.nl [IPv6:2001:610:1108:5010::131]) by mx1.stack.nl (Postfix) with ESMTP id 6CBF5B80A0; Fri, 6 Jun 2014 21:50:34 +0200 (CEST) Received: by snail.stack.nl (Postfix, from userid 1677) id 58CCE28497; Fri, 6 Jun 2014 21:50:34 +0200 (CEST) Date: Fri, 6 Jun 2014 21:50:34 +0200 From: Jilles Tjoelker To: Julio Merino Subject: Re: Turning TESTS on by default Message-ID: <20140606195034.GA75401@stack.nl> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jun 2014 19:50:37 -0000 On Fri, Jun 06, 2014 at 03:14:52PM -0400, Julio Merino wrote: > TL;DR > ----- > I plan to turn the TESTS src.conf knob ON by default on Tuesday once I > have been able to perform enough sanity-checks of the build and all of > them pass. > The impact of this is that the FreeBSD Test Suite (see tests(7)) will > be built and installed by default under /usr/tests/ along with the > private atf libraries and binaries. There should be no other changes > and this should be transparent to everyone. > If this happens to break the world in any way, we can trivially roll > the change back to fix the fallout. > Some details > ------------ > TESTS was never intended to be disabled by default. However, the > original patches that were committed months ago related to this > feature broke the build and the easiest way out (instead of reverting > the commits) was to set the knob to disabled. Unfortunately, it stayed > that way even after the discovered problems were fixed. > I am confident enough now that we have ironed out all major issues > that this might introduce, so it is about time to enable TESTS by > default again in HEAD. > The benefits of this are that 1) we allow end users (especially > consumers of binary releases!) to run the tests out of the box, as it > has always been intended; and 2) we will be able to run the official > release builds through testing via Jenkins, instead of having to issue > custom builds. > Actual change: https://phabric.freebsd.org/D188 > I will update this thread when the change is committed and/or with any > updates. > Please let me know if I'm missing anything. This is certainly useful, but please fix installworld from a read-only (e.g. NFS) /usr/obj first. I reported this a while ago in http://lists.freebsd.org/pipermail/freebsd-testing/2014-May/000384.html "build Kyuafile.auto during buildworld, not installworld". This message includes patches, although they are a bit ugly. -- Jilles Tjoelker