From owner-freebsd-multimedia@freebsd.org Mon Jul 17 20:49:15 2017 Return-Path: Delivered-To: freebsd-multimedia@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ECD91DA049D for ; Mon, 17 Jul 2017 20:49:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id D3F0A70BB3 for ; Mon, 17 Jul 2017 20:49:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id D069BDA049C; Mon, 17 Jul 2017 20:49:15 +0000 (UTC) Delivered-To: multimedia@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D01D0DA049B for ; Mon, 17 Jul 2017 20:49:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BE3A370BB2 for ; Mon, 17 Jul 2017 20:49:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v6HKnFbm008145 for ; Mon, 17 Jul 2017 20:49:15 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: multimedia@FreeBSD.org Subject: [Bug 220785] audio/jack: Add and enable COOKEDMODE option, Use GitHub Date: Mon, 17 Jul 2017 20:49:15 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-patch, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: jbeich@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: multimedia@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? merge-quarterly? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jul 2017 20:49:16 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220785 --- Comment #15 from Jan Beich --- Comment on attachment 184450 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D184450 patch > +COOKEDMODE_CFLAGS+=3D -DOPTION_COOKEDMODE Can you move this one down as well, closer to other option helpers? It only takes effect when both OPTIONS_DEFINE and PORT_OPTIONS (i.e. options select= ed by user) contain COOKEDMODE. (In reply to Yuri Victorovich from comment #13) > Also, RTCPU isn't the same as DYNSIMD. Looking at the code DYNSIMD seems to use CPUID check to determine which (if any) of SIMD optimizations to use. Not sure how it's different from RTCPU in mplayer, ffmpeg or libvpx. > Changing CFLAGS+=3D to CFLAGS=3D strips -O flag from almost all compilati= on commands. _CFLAGS option helper i.e., COOKEDMODE_CFLAGS in this case. Nothing else is expected to modify it unlike CFLAGS which has -O2 via /usr/share/mk/sys.mk, -fstack-protector via $PORTSDIR/Mk/bsd.ssp.mk, etc. --=20 You are receiving this mail because: You are the assignee for the bug.=