From owner-svn-src-head@freebsd.org Fri Jan 25 22:29:21 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5B09A14C54FA; Fri, 25 Jan 2019 22:29:21 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4D60F763A4; Fri, 25 Jan 2019 22:29:20 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x0PMTGhJ090515; Fri, 25 Jan 2019 14:29:16 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id x0PMTGum090514; Fri, 25 Jan 2019 14:29:16 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201901252229.x0PMTGum090514@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r343440 - head/bin/sh In-Reply-To: To: Edward Napierala Date: Fri, 25 Jan 2019 14:29:16 -0800 (PST) CC: rgrimes@freebsd.org, src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 4D60F763A4 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.95 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.95)[-0.948,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2019 22:29:21 -0000 > pt., 25 sty 2019 o 19:57 Rodney W. Grimes > napisa?(a): > > > > > Author: trasz > > > Date: Fri Jan 25 17:09:26 2019 > > > New Revision: 343440 > > > URL: https://svnweb.freebsd.org/changeset/base/343440 > > > > > > Log: > > > Comment out the default sh(1) aliases for root, introduced in r343416. > > > The rest of this stuff is still to be discussed, but I think at this > > > point we have the agreement that the aliases should go. > > > > > > MFC after: 2 weeks > > > Sponsored by: DARPA, AFRL > > > > Please just revert this and the prior commit out, and when > > the path forward is clear commit it. I would not want any of this > > merged to 12/ or 11/ until the time that it is all settled. > > Oops, my bad - neither this nor the previous commit is supposed > to be MFC-ed; the "2 weeks" above comes from my default Subversion > config. > > Regarding the backoff - just a few hours ago you said you don't have > any problem with this, except for aliases and the default ENV. The > aliases problem has been addressed, and you hadn't yet responded > to my explanations regarding the ENV. Another committer asked for > backoff, because "sh is not an interactive shell", while in fact sh(1) > is FreeBSD's default interactive shell except for root. Finally, there's > one person who asked for revert, but without giving any reasons > whatsoever. > > So far nobody had proposed any scenario where this would break > anything, or even affect existing users. It seems like a typical bikeshed > situation. Within hours of your initial commit you had myself, ian and cy all in opposition to this change , devin asked for a revert, first privately to me which I encouraged a public posting of. Thats four people who want this removed. I have now asked publically for a revert. Thats 2 public request for revert. The hat was only about the MFC statement which you have retracted. Just back it out and we can come to a better solution. Especially dependent on the outcome of Bapts mksh proposal. -- Rod Grimes rgrimes@freebsd.org