From owner-svn-src-head@FreeBSD.ORG Thu Nov 10 10:08:44 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9C54C106567A; Thu, 10 Nov 2011 10:08:44 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id E997D8FC1E; Thu, 10 Nov 2011 10:08:43 +0000 (UTC) Received: from alf.home (alf.kiev.zoral.com.ua [10.1.1.177]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id pAAA8dtj023557 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 10 Nov 2011 12:08:39 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from alf.home (kostik@localhost [127.0.0.1]) by alf.home (8.14.5/8.14.5) with ESMTP id pAAA8dDk074865; Thu, 10 Nov 2011 12:08:39 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by alf.home (8.14.5/8.14.5/Submit) id pAAA8dap074864; Thu, 10 Nov 2011 12:08:39 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: alf.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 10 Nov 2011 12:08:39 +0200 From: Kostik Belousov To: Pawel Jakub Dawidek Message-ID: <20111110100839.GK50300@deviant.kiev.zoral.com.ua> References: <201111091725.pA9HPhXh092218@svn.freebsd.org> <20111109173128.GF50300@deviant.kiev.zoral.com.ua> <20111110062322.GA1696@garage.freebsd.pl> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Q7Dt3iDhSkbxWkBL" Content-Disposition: inline In-Reply-To: <20111110062322.GA1696@garage.freebsd.pl> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.9 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r227394 - in head/sys: amd64/amd64 i386/i386 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Nov 2011 10:08:44 -0000 --Q7Dt3iDhSkbxWkBL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 10, 2011 at 07:23:23AM +0100, Pawel Jakub Dawidek wrote: > On Wed, Nov 09, 2011 at 07:31:28PM +0200, Kostik Belousov wrote: > > On Wed, Nov 09, 2011 at 05:25:43PM +0000, Konstantin Belousov wrote: > > > Author: kib > > > Date: Wed Nov 9 17:25:43 2011 > > > New Revision: 227394 > > > URL: http://svn.freebsd.org/changeset/base/227394 > > >=20 > > > Log: > > > Stopped process may legitimately have some threads sleeping and not > > > suspended, if the sleep is uninterruptible. > > Even more, stopped process might have some threads still running in the > > kernel mode, or inhibited due to wait on blockable locks. I was unable > > to design an expression that would assert that such thread will be stop= ped > > at the kernel->user boundary. > >=20 > > The assertion itself is useful and catched several bugs, but theoretica= lly > > can cause false positives. If any report of the fired assert for kernel= -mode > > thread is provided, I will remove the assertions. >=20 > If in five years some change will make it to fire and you won't be > around, nobody will remember this e-mail of yours and someone will spend > time on looking for a bug that doesn't exist. >=20 > If we know it can cause false positives, I'd be in favour of removing it > or changing it into a warning or at the very least moving this > information into commit log. Yes, I do agree that removing the assertion is the most straightforward solution, but on the assertion already catched more real bugs then caused headaches (my headache, BTW). Either I change the third or condition to plain P_SHOULDSTOP(), or create a way to assert exactly what I need. --Q7Dt3iDhSkbxWkBL Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iEYEARECAAYFAk67oqcACgkQC3+MBN1Mb4i7UQCbBBAr44zlXh779kHR51peBQZP pTUAnAgkhE+nhoHx84FAffaPMCq6ZIab =P2mO -----END PGP SIGNATURE----- --Q7Dt3iDhSkbxWkBL--