Date: Thu, 19 May 2011 23:51:57 GMT From: Jason Harmening <jason.harmening@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/157193: [patch] multimedia/cx88: update OSVERSION checks in makefile Message-ID: <201105192351.p4JNpvYt004513@red.freebsd.org> Resent-Message-ID: <201105200000.p4K00RA4008187@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 157193
>Category: ports
>Synopsis: [patch] multimedia/cx88: update OSVERSION checks in makefile
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: maintainer-update
>Submitter-Id: current-users
>Arrival-Date: Fri May 20 00:00:26 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Jason Harmening
>Release: 7.4-STABLE
>Organization:
>Environment:
FreeBSD CORONA 7.4-STABLE FreeBSD 7.4-STABLE #0: Sun Apr 24 02:15:54 CDT 2011 jason@CORONA:/usr/obj/usr/src/sys/CUSTOM amd64
>Description:
--Use OSVERSION instead of grep output as basis for determining whether kernel provides kmem_alloc_attr()
>How-To-Repeat:
>Fix:
Patch attached with submission follows:
diff -ruN cx88/Makefile /usr/ports/multimedia/cx88/Makefile
--- cx88/Makefile 2011-05-19 18:31:58.000000000 -0500
+++ /usr/ports/multimedia/cx88/Makefile 2011-05-19 18:34:55.000000000 -0500
@@ -2,7 +2,7 @@
# Date created: 7 September 2008
# Whom: jah
#
-# $FreeBSD: ports/multimedia/cx88/Makefile,v 1.14 2011/05/19 08:11:35 culot Exp $
+# $FreeBSD$
#
PORTNAME= cx88
@@ -25,18 +25,12 @@
.include <bsd.port.pre.mk>
-.if ${OSVERSION} < 700055
-IGNORE= requires FreeBSD 7.0-RELEASE or later
+.if (${OSVERSION} < 704000) || ((${OSVERSION} >= 800000) && (${OSVERSION} < 801000))
+IGNORE= requires kernel support for kmem_alloc_attr() (FreeBSD 7.4+, FreeBSD 8.1+)
.endif
.if !exists(${SRC_BASE}/sys/Makefile)
IGNORE= requires kernel source files
.endif
-KMEM_ALLOC_ATTR != ${GREP} -r "kmem_alloc_attr" ${SRC_BASE}/sys
-
-.if ${KMEM_ALLOC_ATTR} == ""
-IGNORE= requires kernel support for kmem_alloc_attr() (FreeBSD 7.4+, FreeBSD 8.1+)
-.endif
-
.include <bsd.port.post.mk>
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201105192351.p4JNpvYt004513>