From owner-freebsd-audit Wed Aug 22 2:19: 9 2001 Delivered-To: freebsd-audit@freebsd.org Received: from robin.mail.pas.earthlink.net (robin.mail.pas.earthlink.net [207.217.120.65]) by hub.freebsd.org (Postfix) with ESMTP id 6017137B40F for ; Wed, 22 Aug 2001 02:18:55 -0700 (PDT) (envelope-from cjc@earthlink.net) Received: from blossom.cjclark.org (dialup-209.245.133.160.Dial1.SanJose1.Level3.net [209.245.133.160]) by robin.mail.pas.earthlink.net (EL-8_9_3_3/8.9.3) with ESMTP id CAA24059; Wed, 22 Aug 2001 02:18:52 -0700 (PDT) Received: (from cjc@localhost) by blossom.cjclark.org (8.11.4/8.11.3) id f7M9Iml76954; Wed, 22 Aug 2001 02:18:48 -0700 (PDT) (envelope-from cjc) Date: Wed, 22 Aug 2001 02:18:48 -0700 From: "Crist J. Clark" To: Peter Pentchev Cc: freebsd-audit@FreeBSD.ORG Subject: Re: syslogd(8) Hostname Upgrade Message-ID: <20010822021848.M313@blossom.cjclark.org> Reply-To: cjclark@alum.mit.edu References: <20010822013841.A76483@blossom.cjclark.org> <20010822114241.C8189@ringworld.oblivion.bg> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010822114241.C8189@ringworld.oblivion.bg>; from roam@ringlet.net on Wed, Aug 22, 2001 at 11:42:41AM +0300 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, Aug 22, 2001 at 11:42:41AM +0300, Peter Pentchev wrote: > On Wed, Aug 22, 2001 at 01:38:41AM -0700, Crist J. Clark wrote: > > I brought this up as a PR (bin/24444) some months ago. I figured I'd > > finally close the PR and add this. > > > > This patch makes syslogd(8) update the hostname when the daemon is > > reinitialized. Before anyone points it out, this is not meant to be a > > security feature. It allows syslogd(8) to update the hostname without > > terminating and restarting the daemon and generates a message logging > > the change, nothing more, nothing less. > > > > I've been running with it for months on -CURRENT and -STABLE with no > > problems. Nit picks anyone? > > Just one, and not a major one at that :) > > [snip] > > /* > > + * Load hostname (may have changed). > > + */ > > + if (signo) > > + (void)strlcpy(oldLocalHostName, LocalHostName, > > + sizeof(oldLocalHostName)); > > Do you really need the (void) here? If you want to make lint and friends > happy, you should put the (void) in a couple of other places, too - like > snprintf(), logmsg(), dprintf().. IMHO, just drop it. No, don't _need_ it. I'll add one to snprintf(3), good catch. However, logmsg() is already a void and dprintf is a macro. -- Crist J. Clark cjclark@alum.mit.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message