From owner-svn-src-head@freebsd.org Fri May 4 22:58:22 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7500FFBA8F8 for ; Fri, 4 May 2018 22:58:22 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: from mail-lf0-x22d.google.com (mail-lf0-x22d.google.com [IPv6:2a00:1450:4010:c07::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id ACAAD82D1E for ; Fri, 4 May 2018 22:58:21 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: by mail-lf0-x22d.google.com with SMTP id b23-v6so33033807lfg.4 for ; Fri, 04 May 2018 15:58:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=multiplay-co-uk.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7LkSp2Mnc7UxVgMyQYZaBWGRngsvnB2JBt/htDOCHE4=; b=dIyVXXuO3ghNqTN28gv9Gdx9uZXmqor+rJ6nG7N3wJcd3rugd5UvZ6WyNH0Mbn7vA6 3EvgtrQ1Qd3AMyaPsScxzhSISnTrBFtWh5xtlUaZddQPchD527NnW4r1xCwoh+BgGVsF AhXoXNIX+AFb/1Yh07T8p5hUfq1jGToTA0DG95EVz76Lr+lpwhcHzomKfPrRLTYHCHAg meABOmhLQUAhZCMrDMM2z5tJhH7T0rS0Unpm2LuMKsa/OYgE8eHWldcpuRmks6kfNnOg PDGkmwerLVKibfGhgRI2fwbdgyH+Sg2nvH4/8zq8f/nBRkkYLxOZA+KJ/6CCQrgYGSPP TODw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7LkSp2Mnc7UxVgMyQYZaBWGRngsvnB2JBt/htDOCHE4=; b=AZl0tElhkHZhkqwMG3ThAh/BPtNWO4DfrBVYZ3M91qUljQ9ez+Amkkebb77q59kmhE ekcfOwR07tVWi7S5Kz06n+PqYo2iWi9TzG/D1NnHf5BKhs928ngdZc8ecs0cJWqJfMwB qvCXQu9mNzxTtbk2naRoYhDsHmY0DnVwmmv71TnmyfLwS14aks+rRkyNZ26r4irqMNJA 7bqQd5ub/O8tWbWbQKrsoULfG0a/pADSopP9gRm10BLyRx+Wi0CZiRSDjwDxflwiu0qf Eg3/17a8KRhSBE6cB0/o/3DBpIo1NSx/oVjo0gJ5KK8Dq+138aDUCR9rv3nWfbzUxUu4 qvaQ== X-Gm-Message-State: ALQs6tBgibvSvr9R+GtAoMMpkkfaLp4CDnAJmDs2yfIF478uW5iPiHBW I9RzfbDuK2Syl0njhCFcd4NIr0dd8lbiYFnM4yfk+g== X-Google-Smtp-Source: AB8JxZoHxM1SI3Pl/pG8aMngTuQ+A8VE7ha66ThsdZpOSVYX8ecDKr+hFSe/tH6TxDfTOsloavPyjszi+6S07J2pI6E= X-Received: by 2002:a19:5209:: with SMTP id m9-v6mr17573475lfb.72.1525474700004; Fri, 04 May 2018 15:58:20 -0700 (PDT) MIME-Version: 1.0 References: <201805042241.w44MfC9E090893@repo.freebsd.org> In-Reply-To: <201805042241.w44MfC9E090893@repo.freebsd.org> From: Steven Hartland Date: Fri, 04 May 2018 22:58:09 +0000 Message-ID: Subject: Re: svn commit: r333266 - head/sys/amd64/amd64 To: Mateusz Guzik Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2018 22:58:22 -0000 Can we get the why in commit messages please? This sort of message doesnt provide anything more that can be obtained from reading the diff, which just leaves us wondering why? I=E2=80=99m sure there is a good reason, but without confirmation we=E2=80= =99re just left guessing. The knock on to this is if some assumption that caused the why changes, anyone looking at this will not be able to make an informed descision that that was the case. On Fri, 4 May 2018 at 23:41, Mateusz Guzik wrote: > Author: mjg > Date: Fri May 4 22:41:12 2018 > New Revision: 333266 > URL: https://svnweb.freebsd.org/changeset/base/333266 > > Log: > amd64: syscall path bcopy -> memcpy > > Modified: > head/sys/amd64/amd64/trap.c > > Modified: head/sys/amd64/amd64/trap.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/amd64/amd64/trap.c Fri May 4 22:33:54 2018 (r333265) > +++ head/sys/amd64/amd64/trap.c Fri May 4 22:41:12 2018 (r333266) > @@ -908,7 +908,7 @@ cpu_fetch_syscall_args(struct thread *td) > error =3D 0; > argp =3D &frame->tf_rdi; > argp +=3D reg; > - bcopy(argp, sa->args, sizeof(sa->args[0]) * 6); > + memcpy(sa->args, argp, sizeof(sa->args[0]) * 6); > if (sa->narg > regcnt) { > KASSERT(params !=3D NULL, ("copyin args with no params!")= ); > error =3D copyin(params, &sa->args[regcnt], > >