Date: Thu, 23 Oct 2008 18:21:27 +0200 From: "=?ISO-8859-1?Q?Marius_N=FCnnerich?=" <marius@nuenneri.ch> To: "Marcel Moolenaar" <xcllnt@mac.com> Cc: Ivan Voras <ivoras@freebsd.org>, freebsd-geom@freebsd.org Subject: Re: [PATCH] Teach geom_label to recognise gpt labels and uuids Message-ID: <b649e5e0810230921t36e0df5bj4408fb7466b3dcdb@mail.gmail.com> In-Reply-To: <FCAC7DF6-16C6-4960-9FA7-4E9EB4112D18@mac.com> References: <b649e5e0810230412u5a80ddb8p3955d5b052fa1896@mail.gmail.com> <gdpnsf$8s2$1@ger.gmane.org> <FCAC7DF6-16C6-4960-9FA7-4E9EB4112D18@mac.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Oct 23, 2008 at 5:57 PM, Marcel Moolenaar <xcllnt@mac.com> wrote: > > On Oct 23, 2008, at 4:41 AM, Ivan Voras wrote: > >> Marius N=FCnnerich wrote: >>> >>> Hi all, >>> >>> I wrote the following patch for geom_label: >>> http://nuenneri.ch/freebsd/geom_label.patch >>> >>> What do you think about it? I would love to hear about some tests. >> >> Do you think it's wise to have two separate directories: /dev/gpt and >> /dev/gpt_uuid? I don't think anyone will mistake the UUID from the label >> if it's in the same directory. Also, if I remember correctly how GPT >> works, UUID is always present but the label is optional? > > Yes, the name/label is optional. > > Something to think about: A system can have multiple disks, > and therefore multiple GPT tables. Each table has its own > UUID (hdr_uuid). This is the UUID of the disk itself in a > way. It's probably a good idea to expose that as well: > /dev/gpt/${hdr_uuid}/${ent_uuid} > /dev/gpt/${hdr_uuid}/${ent_name} I tried something like this but decided against it, no other g_label is like this. If ent_name is not unique on the system only the first one is shown, that's consistent with the normal FS labels. > or even: > /dev/gpt/${hdr_uuid}-${ent_uuid} > /dev/gpt/${hdr_uuid}-${ent_name} These are too long filenames imo. For my taste the ent_uuid is unique enough as a filename, but there should probably be a way to show which partition has which ent_uuid with `gpart show`. I know that you try to keep the interface consistent and the other partition types don't have such a field. Anyway, what do you think about that? BTW, do you know about another partition type which could be exposed like t= his? Thanks for your response! Marius
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b649e5e0810230921t36e0df5bj4408fb7466b3dcdb>