From owner-freebsd-fs@FreeBSD.ORG  Tue Nov 26 20:51:56 2013
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 25A8C6F2
 for <freebsd-fs@freebsd.org>; Tue, 26 Nov 2013 20:51:56 +0000 (UTC)
Received: from dss.incore.de (dss.incore.de [195.145.1.138])
 by mx1.freebsd.org (Postfix) with ESMTP id DE9532C60
 for <freebsd-fs@freebsd.org>; Tue, 26 Nov 2013 20:51:55 +0000 (UTC)
Received: from inetmail.dmz (unknown [10.3.0.4])
 by dss.incore.de (Postfix) with ESMTP id B2E785C025
 for <freebsd-fs@freebsd.org>; Tue, 26 Nov 2013 21:51:47 +0100 (CET)
X-Virus-Scanned: amavisd-new at incore.de
Received: from dss.incore.de ([10.3.0.3])
 by inetmail.dmz (inetmail.dmz [10.3.0.4]) (amavisd-new, port 10024)
 with LMTP id 90T0O9fxIiV2 for <freebsd-fs@freebsd.org>;
 Tue, 26 Nov 2013 21:51:46 +0100 (CET)
Received: from mail.incore (fwintern.dmz [10.0.0.253])
 by dss.incore.de (Postfix) with ESMTP id E3BB05C01D
 for <freebsd-fs@freebsd.org>; Tue, 26 Nov 2013 21:51:46 +0100 (CET)
Received: from bsdmhs.longwitz (unknown [192.168.99.6])
 by mail.incore (Postfix) with ESMTP id 989DD508BA
 for <freebsd-fs@freebsd.org>; Tue, 26 Nov 2013 21:51:46 +0100 (CET)
Message-ID: <529509E2.4090903@incore.de>
Date: Tue, 26 Nov 2013 21:51:46 +0100
From: Andreas Longwitz <longwitz@incore.de>
User-Agent: Thunderbird 2.0.0.19 (X11/20090113)
MIME-Version: 1.0
To: freebsd-fs@freebsd.org
Subject: [ffs] ffs_valloc: free inode /home/19 had 128 blocks
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.16
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs/>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Nov 2013 20:51:56 -0000

I run FreeBSD 8.4-STABLE #0 r256119 and I am confused about the message
coming from the code snippet

 if (DIP(ip, i_blocks) && (fs->fs_flags & FS_UNCLEAN) == 0) {  /* XXX */
         printf("free inode %s/%lu had %ld blocks\n",
             fs->fs_fsmnt, (u_long)ino, (long)DIP(ip, i_blocks));
         DIP_SET(ip, i_blocks, 0);
 }

in the function ffs_valloc(). I see these kernel messages often when a
snapshot is taken on a gjournaled ufs partition with

  mount -u -o noatime -o async -o snapshot /home/.snap/snaptest /home

The inode number (19) is always the inode number of the snapshot file.

I would like to know if the 128 blocks are lost forever. If "yes" there
is really a problem. If "no" then the message is not relevant for
gjournaled file systems and fs->fs_flags should be tested in this way:
    (fs->fs_flags & FS_UNCLEAN|FS_GJOURNAL) == 0

-- 
Andreas Longwitz