From nobody Mon Feb 6 22:34:53 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P9h0F3nV7z3nWMD; Mon, 6 Feb 2023 22:34:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P9h0F3J9gz4JZp; Mon, 6 Feb 2023 22:34:53 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675722893; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RKGcjO+I/xw4/jiodBTShdVCRA4/cV0HRFRyc32cL+8=; b=ANHmy3BM06JZHHcvBvQYJbqcl0HNaa5m1Awdn6Zl429vzH145uiL/LbAVZwfc14CElJOo4 sUoEuhV7t9tY2ylVwOF1ADjM7EjLDDgvACyv2eH5X0jMpzQ3sX4+yNG3oVhFIJrXmv7KhA P8x70kgAJSrkVrF5ryG6skI4wD+HChLQ+Ggurlt2lKfQeJqZhypxIXQGBP4m/aR57Zo54s Eeyi5IR1BGUgmjHbbIPKToAe6yLFfEuGluijox5Hp+hbLlNtU4/lJLooaA0+HvFTZ57h3N XuhegW63vfB2G+QykXDnx+J3ScqMJhVV3F+it0BS9Sx/9vNh+YSDCZX4/CCEcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675722893; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RKGcjO+I/xw4/jiodBTShdVCRA4/cV0HRFRyc32cL+8=; b=T2tgymB6E0luCgNUaof3st6GPJ1CV0dFOp/lucM963CZTcV5Wirgi3XkpG/p11aIypTLsu So5SPNQ1TGjW4c+85OeHNp/CUbw/VyWjbfqVsUMdHh9sZodY7LrrEIM1068WQYlyer7DCs NLLfSzvPabh7TJXkaj5aRGT2CWDd1qMI65m8pcMo4k7PHN5JwwvLcmdvW+P5X0Hkwwkbvz 4N9JBFFjs4bBTkTo7jAO4SstAgVLqgObBALRluE6cPhWRDeIEkVkujuqChOxWDUtxakGR/ gzcx/wxgFIo9z4vPMTaur1VpKbSeor5QC4EOabs7NBdTx+hVck0U/G9zHXTOjQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1675722893; a=rsa-sha256; cv=none; b=paYbeJ9PCcqLaCOHap1e7gemSBG4YeF71wMh9HaKGGUstd+dO0lmgu7jd6ZCLTSNrxMlW5 MFw/RhAUYEOopkQwV6EdKYL5SSCLikaYC8Y8XdArary2uzYY2Kp2sOGrJjRcrWqGjMcgef bhj3wlOs+OFZEMR2Nz2kXQgF2GGmU58YwpaJwSprmAcxe2YpKd7bEYdsiv6p7sGX/AKxVB Mfc1d7dWEpf/Rw7GkpCTlZT3zFIigCaalz1mcXDCHHkubT8yYF8Um19zOtALcaGMlPVNGn QWGh1YA0SPVJr9zTbHVbBqf+c3R2NP23Q6qsYTpLdiUhVaHeXzEldhxI/1ilZg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4P9h0F2F9gzt2F; Mon, 6 Feb 2023 22:34:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 316MYrOQ079039; Mon, 6 Feb 2023 22:34:53 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 316MYrAX079038; Mon, 6 Feb 2023 22:34:53 GMT (envelope-from git) Date: Mon, 6 Feb 2023 22:34:53 GMT Message-Id: <202302062234.316MYrAX079038@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mateusz Guzik Subject: git: 819ed472043c - main - amd64 pmap: patch up a comment in pmap_init_pv_table List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mjg X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 819ed472043c8067d45b5c4608c8a6fb05ff7f04 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=819ed472043c8067d45b5c4608c8a6fb05ff7f04 commit 819ed472043c8067d45b5c4608c8a6fb05ff7f04 Author: Mateusz Guzik AuthorDate: 2023-02-06 22:33:28 +0000 Commit: Mateusz Guzik CommitDate: 2023-02-06 22:33:28 +0000 amd64 pmap: patch up a comment in pmap_init_pv_table Requested by: jhb --- sys/amd64/amd64/pmap.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/sys/amd64/amd64/pmap.c b/sys/amd64/amd64/pmap.c index a86487310aff..a31cdb2a8215 100644 --- a/sys/amd64/amd64/pmap.c +++ b/sys/amd64/amd64/pmap.c @@ -2314,9 +2314,13 @@ pmap_init_pv_table(void) int domain, i, j, pages; /* - * We strongly depend on the size being a power of two, so the assert - * is overzealous. However, should the struct be resized to a - * different power of two, the code below needs to be revisited. + * For correctness we depend on the size being evenly divisible into a + * page. As a tradeoff between performance and total memory use, the + * entry is 64 bytes (aka one cacheline) in size. Not being smaller + * avoids false-sharing, but not being 128 bytes potentially allows for + * avoidable traffic due to adjacent cacheline prefetcher. + * + * Assert the size so that accidental changes fail to compile. */ CTASSERT((sizeof(*pvd) == 64));