From owner-svn-ports-head@FreeBSD.ORG Sun Mar 31 16:17:11 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id B41786F4 for ; Sun, 31 Mar 2013 16:17:11 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-da0-x230.google.com (mail-da0-x230.google.com [IPv6:2607:f8b0:400e:c00::230]) by mx1.freebsd.org (Postfix) with ESMTP id 8AAE6266 for ; Sun, 31 Mar 2013 16:17:11 +0000 (UTC) Received: by mail-da0-f48.google.com with SMTP id p8so763935dan.7 for ; Sun, 31 Mar 2013 09:17:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=OZZ5qUcuh3aorhQY5XBN4NL7ASsS2NsCnYJlzHvMq38=; b=h1wQtq7syO6XK2xY2jCfxyB2ZELcXo5UhrfqaiL04euhC9uwxfSOEQtZfwCAF4wdpL ETKRecu6Qrex7jKeNqYbTr7pWYkNXzyHx2UnDq3RvG0oybafwxijFD89Y3WCp68HLKe5 pUB8TE2z/v/nUIRTI+kOAy5Ia0xot3wY5zK4M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=OZZ5qUcuh3aorhQY5XBN4NL7ASsS2NsCnYJlzHvMq38=; b=Ihiz3YzkBfVIvxsKFFWwVdVeDKFBpwK+n+uhLGXo91Ki6krYqRERnhqRrt4nPycXEa 6EMsT3p+d+wcqtl/+MO7DnLl7H9a5qZ1uxv8SF5uVMDslugL4DSIWPWzO3QgdkG/vzvB dNDhd3ELHN6ICx5Do8TI0MzMS+lrOZFPZTGPzvhinSRPdKcmQ2dcHFrXU5ip9b2Y9gR6 SNl+2h0HkNBch+1fuqxDt/c/McOCtij6Z1Z+T+sdxTpJ8sskEc2Q94pkw7EYOHiz/C5y uqWCm2RylWyG5CXE+vvCFOcugfLXaGmCrddCQANnlq9wgslyjS71yDwVCfZCfch3p0fq Q4pw== X-Received: by 10.66.176.43 with SMTP id cf11mr14793220pac.28.1364746631088; Sun, 31 Mar 2013 09:17:11 -0700 (PDT) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.66.246.201 with HTTP; Sun, 31 Mar 2013 09:16:41 -0700 (PDT) In-Reply-To: <5158602E.7070101@FreeBSD.org> References: <201303302045.r2UKj1wS062090@svn.freebsd.org> <51575F46.3050807@freebsd.org> <5158602E.7070101@FreeBSD.org> From: Eitan Adler Date: Sun, 31 Mar 2013 12:16:41 -0400 X-Google-Sender-Auth: cHZY3iywAFinzH7B2lD9i_amByw Message-ID: Subject: Re: svn commit: r315624 - head/net/wireshark To: Bryan Drewery Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQlP6KE9NLdGwsHlKkVOKuCaVS6IriC9xUUDS5NGy0Gp1zzhYSM6457tJ662nrxV2OJ50z7X Cc: "svn-ports-head@freebsd.org" , svn-ports-all@freebsd.org, "ports-committers@freebsd.org" , Chris Rees , Joe Marcus Clarke , Niclas Zeising , =?UTF-8?Q?Beat_G=C3=A4tzi?= X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Mar 2013 16:17:11 -0000 On 31 March 2013 12:11, Bryan Drewery wrote: > On 3/31/2013 11:02 AM, Chris Rees wrote: >> On 30 March 2013 21:55, Niclas Zeising wrote: >>> On 03/30/13 21:45, Joe Marcus Clarke wrote: >>>> Author: marcus >>>> Date: Sat Mar 30 20:45:00 2013 >>>> New Revision: 315624 >>>> URL: http://svnweb.freebsd.org/changeset/ports/315624 >>>> >>>> Log: >>>> Make pkgconfig an explicit dependency of tshark. >>>> >>>> Modified: >>>> head/net/wireshark/Makefile >>>> >>>> Modified: head/net/wireshark/Makefile >>>> ============================================================================== >>>> --- head/net/wireshark/Makefile Sat Mar 30 18:54:34 2013 (r315623) >>>> +++ head/net/wireshark/Makefile Sat Mar 30 20:45:00 2013 (r315624) >>>> @@ -75,7 +75,7 @@ USE_GNOME+= gtk20 >>>> WIRESHARK_LIBS+=${PTHREAD_LIBS} >>>> .else >>>> PLIST_SUB+= WIRESHARK="@comment wireshark not built" >>>> -USE_GNOME+= glib20 >>>> +USE_GNOME+= glib20 pkgconfig >>>> CONFIGURE_ARGS+= --enable-wireshark=no \ >>>> --disable-gtktest >>>> .endif >>>> >>> >>> You should use USE_PKGCONFIG=build instead. >>> >>> A completely other thing: >>> Isn't the ports tree frozen these days and require a Approved by: >>> portmgr line in the commit msg? Perhaps something isn't working as it >>> should there. >>> Regards! >> >> Those hooks are not working at the moment, though I don't remember if >> I specifically told Beat about it or just complained. >> >> I've copied him in just in case he didn't know. >> >> Another example: >> >> http://svnweb.freebsd.org/ports/svnadmin/conf/access?revision=314635&view=markup >> >> Chris >> > > The hook is working. portmgr are explicitly exempt from the check for > "Approved by". See svnadmin/hooks/scripts/approvecheck.pl To reduce confusion can we remove this? portmgr can use "Approved by: portmgr (implicit)" -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams