From owner-svn-src-head@freebsd.org Wed May 9 19:09:34 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E8707FC8C3C; Wed, 9 May 2018 19:09:33 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 38343731B2; Wed, 9 May 2018 19:09:32 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id GUQHfoPpwSzNNGUQJfE2VR; Wed, 09 May 2018 13:06:48 -0600 X-Authority-Analysis: v=2.3 cv=KuxjJ1eN c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=VUJBJC2UJ8kA:10 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=LiUY94_sdSCVOa8-Wv0A:9 a=CjuIK1q_8ugA:10 a=SgE0gsHR3q8A:10 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 Received: from slippy.cwsent.com (slippy8 [10.2.2.6]) by spqr.komquats.com (Postfix) with ESMTPS id 9E76932D; Wed, 9 May 2018 12:06:45 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id w49J6Tnr003658; Wed, 9 May 2018 12:06:29 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id w49J6TKd003655; Wed, 9 May 2018 12:06:29 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201805091906.w49J6TKd003655@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: "Poul-Henning Kamp" cc: John Baldwin , Cy Schubert , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r333393 - head/sys/contrib/ipfilter/netinet In-Reply-To: Message from "Poul-Henning Kamp" of "Wed, 09 May 2018 17:09:56 -0000." <27445.1525885796@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 09 May 2018 12:06:29 -0700 X-CMAE-Envelope: MS4wfOW9mrMXsog4Fo8RTrAuIqVizgcW7faDW3njT6o1+O39QRI/u0vLcgR8nk6h6Fx10vkLljivo12vzNzwYkOP1oVAa//5ZpsQTz6Cy7BbUjOYqanX6BOF u7Qe7rs089UZKDVFi6h+i6ogjVEhf3MVQIiSx/0ZBJ5ebrz4kJxFOd8KYQmyJ1AkhuDUJPAZ8E4cqlKxWANx4AQ/3AnHrGRwzXcXplZ0Czjn9Sfc/K3ORWjt bskhvE2CgbfnYOagANomOOOGZgb6guNx5MI9JDWOKLFXOvzi4UsObJSz2onkorpca4mzO96DwvKa1nNMbfSHls7v4KBjhmFmyyPepaekrHc= X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 19:09:34 -0000 In message <27445.1525885796@critter.freebsd.dk>, "Poul-Henning Kamp" writes: > -------- > In message <4065288.o9QKfFzp22@ralph.baldwin.cx>, John Baldwin writes: > > >Hmm, normal FreeBSD style here is to use /* FALLTHROUGH */, and there are > >three other instances of that style in ipfilter already (and none others > >using this comment style). > > Not to mention that code analysis tools like lint, FlexeLint, Coverity etc > expect /* FALLTHROUGH */ comments. Thanks everyone. Just fixed in r333427. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.