From owner-freebsd-bugs@FreeBSD.ORG Sat Mar 6 09:40:01 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E9197106566C for ; Sat, 6 Mar 2010 09:40:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id ACF358FC0A for ; Sat, 6 Mar 2010 09:40:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o269e1gI071268 for ; Sat, 6 Mar 2010 09:40:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o269e1d4071267; Sat, 6 Mar 2010 09:40:01 GMT (envelope-from gnats) Resent-Date: Sat, 6 Mar 2010 09:40:01 GMT Resent-Message-Id: <201003060940.o269e1d4071267@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Henning Petersen Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7EB021065673 for ; Sat, 6 Mar 2010 09:38:39 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 6EEC28FC17 for ; Sat, 6 Mar 2010 09:38:39 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o269ccbS097987 for ; Sat, 6 Mar 2010 09:38:38 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o269ccgC097986; Sat, 6 Mar 2010 09:38:38 GMT (envelope-from nobody) Message-Id: <201003060938.o269ccgC097986@www.freebsd.org> Date: Sat, 6 Mar 2010 09:38:38 GMT From: Henning Petersen To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/144505: Error in macro CALC_COEFF2. X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Mar 2010 09:40:02 -0000 >Number: 144505 >Category: kern >Synopsis: Error in macro CALC_COEFF2. >Confidential: no >Severity: serious >Priority: high >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Mar 06 09:40:01 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Henning Petersen >Release: Freebsd-current >Organization: >Environment: >Description: Error in macro CALC_COEFF2, rename tmp[3] to _v. Found by cppcheck. >How-To-Repeat: >Fix: diff -u -r1.10 if_bwn.c --- sys/dev/bwn/if_bwn.c 3 Mar 2010 20:06:09 -0000 1.10 +++ sys/dev/bwn/if_bwn.c 6 Mar 2010 09:06:04 -0000 @@ -12910,9 +12910,9 @@ int _t; \ _t = _x - 11; \ if (_t >= 0) \ - tmp[3] = (_y << (31 - _x)) / (_z >> _t); \ + _v = (_y << (31 - _x)) / (_z >> _t); \ else \ - tmp[3] = (_y << (31 - _x)) / (_z << -_t); \ + _v = (_y << (31 - _x)) / (_z << -_t); \ } while (0) struct bwn_phy_lp_iq_est ie; uint16_t v0, v1; Patch attached with submission follows: diff -u -r1.10 if_bwn.c --- sys/dev/bwn/if_bwn.c 3 Mar 2010 20:06:09 -0000 1.10 +++ sys/dev/bwn/if_bwn.c 6 Mar 2010 09:06:04 -0000 @@ -12910,9 +12910,9 @@ int _t; \ _t = _x - 11; \ if (_t >= 0) \ - tmp[3] = (_y << (31 - _x)) / (_z >> _t); \ + _v = (_y << (31 - _x)) / (_z >> _t); \ else \ - tmp[3] = (_y << (31 - _x)) / (_z << -_t); \ + _v = (_y << (31 - _x)) / (_z << -_t); \ } while (0) struct bwn_phy_lp_iq_est ie; uint16_t v0, v1; >Release-Note: >Audit-Trail: >Unformatted: