From owner-freebsd-hackers@FreeBSD.ORG  Mon Oct 26 20:09:49 2009
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F18F0106566C
	for <hackers@freebsd.org>; Mon, 26 Oct 2009 20:09:49 +0000 (UTC)
	(envelope-from uqs@spoerlein.net)
Received: from acme.spoerlein.net (cl-43.dus-01.de.sixxs.net
	[IPv6:2a01:198:200:2a::2])
	by mx1.freebsd.org (Postfix) with ESMTP id 5E5DB8FC13
	for <hackers@freebsd.org>; Mon, 26 Oct 2009 20:09:49 +0000 (UTC)
Received: from roadrunner.spoerlein.net (pD9E5C51D.dip.t-dialin.net
	[217.229.197.29])
	by acme.spoerlein.net (8.14.3/8.14.3) with ESMTP id n9QK9iY3063462
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <hackers@freebsd.org>; Mon, 26 Oct 2009 21:09:47 +0100 (CET)
	(envelope-from uqs@spoerlein.net)
Received: from roadrunner.spoerlein.net (localhost [127.0.0.1])
	by roadrunner.spoerlein.net (8.14.3/8.14.3) with ESMTP id
	n9QK9avk013607
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
	for <hackers@freebsd.org>; Mon, 26 Oct 2009 21:09:36 +0100 (CET)
	(envelope-from uqs@spoerlein.net)
Received: (from uqs@localhost)
	by roadrunner.spoerlein.net (8.14.3/8.14.3/Submit) id n9QK9ZiR013606
	for hackers@freebsd.org; Mon, 26 Oct 2009 21:09:35 +0100 (CET)
	(envelope-from uqs@spoerlein.net)
Date: Mon, 26 Oct 2009 21:09:35 +0100
From: Ulrich =?utf-8?B?U3DDtnJsZWlu?= <uqs@spoerlein.net>
To: hackers@freebsd.org
Message-ID: <20091026200935.GA13602@roadrunner.spoerlein.net>
Mail-Followup-To: hackers@freebsd.org
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="uAKRQypu60I7Lcqm"
Content-Disposition: inline
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: 
Subject: in_cksum.h for sparc64 missing ifdef KERNEL?
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Oct 2009 20:09:50 -0000


--uAKRQypu60I7Lcqm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi,

while trying to cleanup some WARNS issues under sbin/, I noticed that
natd(8) fails to compile for sparc64 only, due to missing "struct
mbuf" declaration in in_cksum.h. Comparing that header to other arch's
headers leads me to believe an #ifdef is missing.

See attached patch, but please note that I do not have the resources to
run this through a make universe right now.

Regards,
Uli

--uAKRQypu60I7Lcqm
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="cksum.diff"

1618[tip]   350410f79434   2009-10-26 21:02 +0100   uqs
  Put this under KERNEL just like all other arch do.

diff -r 5558195fb93d -r 350410f79434 sys/sparc64/include/in_cksum.h
--- a/sys/sparc64/include/in_cksum.h	Mon Oct 26 19:57:23 2009 +0100
+++ b/sys/sparc64/include/in_cksum.h	Mon Oct 26 21:02:06 2009 +0100
@@ -164,6 +164,8 @@
 	return (__ret);
 }
 
+#ifdef _KERNEL
 u_short	in_cksum_skip(struct mbuf *m, int len, int skip);
+#endif
 
 #endif /* _MACHINE_IN_CKSUM_H_ */


--uAKRQypu60I7Lcqm--