From owner-svn-src-all@FreeBSD.ORG  Tue Aug 21 23:55:29 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id E403D106566C;
	Tue, 21 Aug 2012 23:55:29 +0000 (UTC)
	(envelope-from jhibbits@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id CF1848FC0A;
	Tue, 21 Aug 2012 23:55:29 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q7LNtTAZ029597;
	Tue, 21 Aug 2012 23:55:29 GMT
	(envelope-from jhibbits@svn.freebsd.org)
Received: (from jhibbits@localhost)
	by svn.freebsd.org (8.14.4/8.14.4/Submit) id q7LNtTh6029594;
	Tue, 21 Aug 2012 23:55:29 GMT
	(envelope-from jhibbits@svn.freebsd.org)
Message-Id: <201208212355.q7LNtTh6029594@svn.freebsd.org>
From: Justin Hibbits <jhibbits@FreeBSD.org>
Date: Tue, 21 Aug 2012 23:55:29 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r239548 - head/sys/powerpc/powermac
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Aug 2012 23:55:30 -0000

Author: jhibbits
Date: Tue Aug 21 23:55:29 2012
New Revision: 239548
URL: http://svn.freebsd.org/changeset/base/239548

Log:
  phandle_t is unsigned, and OF_finddevice() returns (phandle_t)(-1) on
  failure, so check for that instead of 0.
  
  While here, provide a better description for ATI backlight driver.
  
  Reported by:	jchandra@
  MFC after:	3 days

Modified:
  head/sys/powerpc/powermac/atibl.c
  head/sys/powerpc/powermac/nvbl.c

Modified: head/sys/powerpc/powermac/atibl.c
==============================================================================
--- head/sys/powerpc/powermac/atibl.c	Tue Aug 21 23:44:47 2012	(r239547)
+++ head/sys/powerpc/powermac/atibl.c	Tue Aug 21 23:55:29 2012	(r239548)
@@ -98,7 +98,7 @@ atibl_probe(device_t dev)
 
 	handle = OF_finddevice("mac-io/backlight");
 
-	if (handle <= 0)
+	if (handle == -1)
 		return (ENXIO);
 
 	if (OF_getprop(handle, "backlight-control", &control, sizeof(control)) < 0)
@@ -107,7 +107,7 @@ atibl_probe(device_t dev)
 	if (strcmp(control, "ati") != 0)
 		return (ENXIO);
 
-	device_set_desc(dev, "PowerBook backlight");
+	device_set_desc(dev, "PowerBook backlight for ATI graphics");
 
 	return (0);
 }

Modified: head/sys/powerpc/powermac/nvbl.c
==============================================================================
--- head/sys/powerpc/powermac/nvbl.c	Tue Aug 21 23:44:47 2012	(r239547)
+++ head/sys/powerpc/powermac/nvbl.c	Tue Aug 21 23:55:29 2012	(r239548)
@@ -94,7 +94,7 @@ nvbl_probe(device_t dev)
 
 	handle = OF_finddevice("mac-io/backlight");
 
-	if (handle <= 0)
+	if (handle == -1)
 		return (ENXIO);
 
 	if (OF_getprop(handle, "backlight-control", &control, sizeof(control)) < 0)