From nobody Sun Dec 14 13:46:17 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dTkxQ2Bn3z6KD4j for ; Sun, 14 Dec 2025 13:46:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dTkxQ0Pm9z3kdD for ; Sun, 14 Dec 2025 13:46:18 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1765719978; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lkjKSlvaYiFLb+tL9M5P/ayD7et+aDMZfyfAugxNT3M=; b=IHMMr0Pba9ewMDf+gBj8n4qAM2SwSUQv4uZR04ts6EKh5ABGci00e1hW01iFZQlQVi9uD3 0nHmO65lMMWf3DBpJ1/E/zzogN6KzRaCpwKr0Z/lW6y8u/y5M3zKmIjDDrC4Koul45lgPd en/1ESNN044xrN1IMEAuqiAmdLHfGXYdUGfk6pGhN7LOlWsf+aXnFpE+Jp6aSyhHJtlEyq ylEn9cA7Mintzs/uCQYYfQmy42y2tPpPpgB99zSAbKiDltck5HX3rh3XIC0qBX0/PlI2L1 KJ7mZr7QQWoYxPpf7bdC9XDJylsVj89Ldx9N7Uc1nOn3h7WRYr5LPJ1nAhGTZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1765719978; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lkjKSlvaYiFLb+tL9M5P/ayD7et+aDMZfyfAugxNT3M=; b=V74KrZN2GnFUmfuDYUgK6Juagh0ndYZAMNMmhWHkj8AuC5Lcui7rYg0paFsdEQWPNSau8C byvNCWfZJ5tNGU6jJ5tDBYwx+nYPghtX6ll04lU0VZvV8Dzf5lbh3AWUiM0Vr2lAnEqA0P 1tW4JybbmEj861Co7ZukVj6BHzcgzQlwVBNFnrNCk5LI0wdTURG9hsxgH+rJ0HuxsSDIfd qVMpZ1aLBlT/Vm7MAxz23XjyJQbuftFFZ2FMkiCZc1lVup2jRm5Dz7DIdPTReVZfX/+dzL miyiGGdrAy97NPZCp9WkAgHBzzCTlstwxvEd6+gJC751lDEdiK8FAbpHPOAtKA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1765719978; a=rsa-sha256; cv=none; b=TjjUFm8vCYH8BnoHFJUUBx9kzczovlG+sipcvfaM4Uf5aDm4hplhSPZE9GH7Z0/omDjItl qhndhMD8DsfEsLNUDwKlt5BHqFc78bKSlliv+Ap1UGh8lRzyfL53klK5p4+UIb/2mu4DNX cgP18MRiZrYacM1SDxiasKa9VIFoyr7kmXaB7AVK/e03ozc2U5S9FO5D5AYmuMgZiutsGP OO+1ExMRxbRo+zjCOkFpSIzisrfRX3LIkSGKwqoALuzkUhqZLDBoQZBO8DORXB1mpFbstu njjQc+EzDGaVfNJPQ5dXTbtFiYu80tYbpZMXH7aALlRVIQWLEQHSMXKovkcYUg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dTkxP73j3zc3G for ; Sun, 14 Dec 2025 13:46:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 28fc8 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 14 Dec 2025 13:46:17 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: 026d962ef14d - main - proc: Fix proc_init / proc_dtor ordering issues List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 026d962ef14dafe19fa73361bea6dcc95f141dfa Auto-Submitted: auto-generated Date: Sun, 14 Dec 2025 13:46:17 +0000 Message-Id: <693ebfa9.28fc8.59e9115c@gitrepo.freebsd.org> The branch main has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=026d962ef14dafe19fa73361bea6dcc95f141dfa commit 026d962ef14dafe19fa73361bea6dcc95f141dfa Author: Dag-Erling Smørgrav AuthorDate: 2025-12-14 13:16:22 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2025-12-14 13:16:37 +0000 proc: Fix proc_init / proc_dtor ordering issues * Move the initialization of p_ktr into proc_init() and make the check in proc_dtor() unconditional. Prior to this, it was possible to fail and invoke proc_dtor() after the first thread had been created (which was the condition for checking p_ktr in proc_dtor()) but before p_ktr had been initialized. * Move the p_klist initialization in fork1() past the last possible failure point so we don't have to free it on failure. We didn't, which meant we were leaking a knlist every time we failed to fork due to hitting the resource limit. PR: 291470 MFC after: 1 week Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D54215 --- sys/kern/kern_fork.c | 4 ++-- sys/kern/kern_proc.c | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/sys/kern/kern_fork.c b/sys/kern/kern_fork.c index 8b237b6dbd17..961d72c46d2c 100644 --- a/sys/kern/kern_fork.c +++ b/sys/kern/kern_fork.c @@ -1065,8 +1065,6 @@ fork1(struct thread *td, struct fork_req *fr) #ifdef MAC mac_proc_init(newproc); #endif - newproc->p_klist = knlist_alloc(&newproc->p_mtx); - STAILQ_INIT(&newproc->p_ktr); /* * Increment the count of procs running with this uid. Don't allow @@ -1079,6 +1077,8 @@ fork1(struct thread *td, struct fork_req *fr) chgproccnt(cred->cr_ruidinfo, 1, 0); } + newproc->p_klist = knlist_alloc(&newproc->p_mtx); + do_fork(td, fr, newproc, td2, vm2, fp_procdesc); error = 0; goto cleanup; diff --git a/sys/kern/kern_proc.c b/sys/kern/kern_proc.c index 6e56664d12ce..8f86ce349e30 100644 --- a/sys/kern/kern_proc.c +++ b/sys/kern/kern_proc.c @@ -241,11 +241,9 @@ proc_dtor(void *mem, int size, void *arg) p = (struct proc *)mem; td = FIRST_THREAD_IN_PROC(p); if (td != NULL) { -#ifdef INVARIANTS KASSERT((p->p_numthreads == 1), - ("bad number of threads in exiting process")); - KASSERT(STAILQ_EMPTY(&p->p_ktr), ("proc_dtor: non-empty p_ktr")); -#endif + ("too many threads in exiting process")); + /* Free all OSD associated to this thread. */ osd_thread_exit(td); ast_kclear(td); @@ -253,6 +251,7 @@ proc_dtor(void *mem, int size, void *arg) /* Make sure all thread destructors are executed */ EVENTHANDLER_DIRECT_INVOKE(thread_dtor, td); } + KASSERT(STAILQ_EMPTY(&p->p_ktr), ("proc_dtor: non-empty p_ktr")); EVENTHANDLER_DIRECT_INVOKE(process_dtor, p); #ifdef KDTRACE_HOOKS kdtrace_proc_dtor(p); @@ -281,6 +280,7 @@ proc_init(void *mem, int size, int flags) p->p_stats = pstats_alloc(); p->p_pgrp = NULL; TAILQ_INIT(&p->p_kqtim_stop); + STAILQ_INIT(&p->p_ktr); return (0); }