From owner-freebsd-new-bus Tue Jul 11 1: 1:28 2000 Delivered-To: freebsd-new-bus@freebsd.org Received: from tele-post-20.mail.demon.net (tele-post-20.mail.demon.net [194.217.242.20]) by hub.freebsd.org (Postfix) with ESMTP id F0D0C37BC6F for ; Tue, 11 Jul 2000 01:01:24 -0700 (PDT) (envelope-from dfr@nlsystems.com) Received: from nlsys.demon.co.uk ([158.152.125.33] helo=herring.nlsystems.com) by tele-post-20.mail.demon.net with esmtp (Exim 2.12 #2) id 13Buyk-0006cT-0K; Tue, 11 Jul 2000 08:01:19 +0000 Received: from salmon.nlsystems.com (salmon.nlsystems.com [10.0.0.3]) by herring.nlsystems.com (8.9.3/8.8.8) with ESMTP id MAA02522; Mon, 10 Jul 2000 12:30:09 +0100 (BST) (envelope-from dfr@nlsystems.com) Date: Tue, 11 Jul 2000 09:04:41 +0100 (BST) From: Doug Rabson To: Jeroen Ruigrok/Asmodai Cc: new-bus@freebsd.org Subject: Re: bus_config_intr() In-Reply-To: <20000710204018.F86887@daemon.ninth-circle.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-new-bus@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Mon, 10 Jul 2000, Jeroen Ruigrok/Asmodai wrote: > Poul-Henning Kamp was friendly enough to make the following patch: > > http://phk.freebsd.dk/misc/bus_config_intr.patch > > Basically this removes some often duplicated code and wraps it in a > function of itself. I am not quite sure if the name shouldn't be > pcibus_config_intr(), but I welcome arguments, both for and against, > before I commit this to the tree since it makes sense. The if statement "if (res == NULL)" should be "if (*res == NULL)". I have the same reservations as Warner on the use of RF_SHAREABLE. This flag should be passed in probably. -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 20 8442 9037 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-new-bus" in the body of the message