From owner-p4-projects  Fri Jul 12 16:47:57 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 5C13237B401; Fri, 12 Jul 2002 16:47:49 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E6B3937B400
	for <perforce@freebsd.org>; Fri, 12 Jul 2002 16:47:48 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DE69443E88
	for <perforce@freebsd.org>; Fri, 12 Jul 2002 16:47:15 -0700 (PDT)
	(envelope-from peter@freebsd.org)
Received: from freefall.freebsd.org (perforce@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.4/8.12.4) with ESMTP id g6CNl1JU029848
	for <perforce@freebsd.org>; Fri, 12 Jul 2002 16:47:01 -0700 (PDT)
	(envelope-from peter@freebsd.org)
Received: (from perforce@localhost)
	by freefall.freebsd.org (8.12.4/8.12.4/Submit) id g6CNl1UD029845
	for perforce@freebsd.org; Fri, 12 Jul 2002 16:47:01 -0700 (PDT)
Date: Fri, 12 Jul 2002 16:47:01 -0700 (PDT)
Message-Id: <200207122347.g6CNl1UD029845@freefall.freebsd.org>
X-Authentication-Warning: freefall.freebsd.org: perforce set sender to peter@freebsd.org using -f
From: Peter Wemm <peter@FreeBSD.org>
Subject: PERFORCE change 14166 for review
To: Perforce Change Reviews <perforce@freebsd.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

http://people.freebsd.org/~peter/p4db/chv.cgi?CH=14166

Change 14166 by peter@peter_xeon on 2002/07/12 16:46:53

	add two more lockchecks.  Unfortunately this panics, because
	vm_page_free_toq() removes pages from the free queue without
	holding the free queue locked.

Affected files ...

.. //depot/projects/pmap/sys/vm/vm_pageq.c#6 edit

Differences ...

==== //depot/projects/pmap/sys/vm/vm_pageq.c#6 (text+ko) ====

@@ -106,6 +106,7 @@
 {
 	struct vpgqueues *vpq;
 
+	LOCKCHECK(queue);
 	vpq = &vm_page_queues[queue];
 	m->queue = queue;
 	TAILQ_INSERT_TAIL(&vpq->pl, m, pageq);
@@ -147,7 +148,9 @@
 {
 	int queue = m->queue;
 	struct vpgqueues *pq;
+
 	if (queue != PQ_NONE) {
+		LOCKCHECK(PQ_FREE);
 		pq = &vm_page_queues[queue];
 		m->queue = PQ_NONE;
 		TAILQ_REMOVE(&pq->pl, m, pageq);

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message