From owner-cvs-src@FreeBSD.ORG  Mon Jul 31 16:32:21 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0A50416A4E2;
	Mon, 31 Jul 2006 16:32:21 +0000 (UTC)
	(envelope-from yar@comp.chem.msu.su)
Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5CF3D43D8A;
	Mon, 31 Jul 2006 16:32:17 +0000 (GMT)
	(envelope-from yar@comp.chem.msu.su)
Received: from comp.chem.msu.su (localhost [127.0.0.1])
	by comp.chem.msu.su (8.13.4/8.13.3) with ESMTP id k6VGWAPg053070;
	Mon, 31 Jul 2006 20:32:10 +0400 (MSD)
	(envelope-from yar@comp.chem.msu.su)
Received: (from yar@localhost)
	by comp.chem.msu.su (8.13.4/8.13.3/Submit) id k6VGWAW8053069;
	Mon, 31 Jul 2006 20:32:10 +0400 (MSD) (envelope-from yar)
Date: Mon, 31 Jul 2006 20:32:09 +0400
From: Yar Tikhiy <yar@comp.chem.msu.su>
To: Marcel Moolenaar <marcel@xcllnt.net>
Message-ID: <20060731163209.GB50797@comp.chem.msu.su>
References: <200607302051.k6UKpfNU011188@repoman.freebsd.org>
	<20060731140951.GC48538@comp.chem.msu.su>
	<EE87FDC1-709D-4B95-9A74-DFF393796664@xcllnt.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <EE87FDC1-709D-4B95-9A74-DFF393796664@xcllnt.net>
User-Agent: Mutt/1.5.9i
Cc: cvs-src@FreeBSD.org, Marcel Moolenaar <marcel@FreeBSD.org>, ru@FreeBSD.org,
	cvs-all@FreeBSD.org, src-committers@FreeBSD.org
Subject: Re: cvs commit: src/usr.sbin/kldxref Makefile
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 31 Jul 2006 16:32:21 -0000

On Mon, Jul 31, 2006 at 09:10:43AM -0700, Marcel Moolenaar wrote:
> 
> On Jul 31, 2006, at 7:09 AM, Yar Tikhiy wrote:
> 
> >On Sun, Jul 30, 2006 at 08:51:41PM +0000, Marcel Moolenaar wrote:
> >>marcel      2006-07-30 20:51:41 UTC
> >>
> >>  FreeBSD src repository
> >>
> >>  Modified files:
> >>    usr.sbin/kldxref     Makefile
> >>  Log:
> >>  Use NO_SHARED=YES to force a static link.
> >>
> >>  Pointed out by: ru@
> >>
> >>  Revision  Changes    Path
> >>  1.9       +1 -1      src/usr.sbin/kldxref/Makefile
> >
> >Perhaps it should be spelled just ``NO_SHARED='' in keeping with
> >the current style?
> 
> I really don't know. Those NO_FOO knobs are not logical in their
> use.
> 
> >  Unfortunately style.Makefile(5) doesn't seem
> >to list this rule...
> 
> Feel free to change my commit to whatever you think is right.

I was sly enough to add Ruslan to Cc in my previous mail :-)
Let's wait for his opinion on this and below.

In the meanwhile I peeked in /usr/share/mk and found that the handling
of NO_* knobs is quite far from being consistent.  For example:

- NO_MAN -- can be just defined ("YES" and "NO" both mean true),
	    handled at <bsd.own.mk> level (note that <bsd.own.mk>
	    is often included separately now and includes some magic);

- NO_OBJ -- can be just defined to be true, handled in <bsd.obj.mk>,
	    which is included from more convenient files like <bsd.prog.mk>;

- NO_SHARED -- must be set to something != "no" for the effect,
	       handled in <bsd.prog.mk>.

I'm unsure if there is a reason behind all this diversity.

-- 
Yar