Date: Thu, 02 Jan 2020 14:22:18 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 242940] games/devilutionX 1.0.0: version update and fixed some issues Message-ID: <bug-242940-7788-ze7ZQ8TgqB@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-242940-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-242940-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D242940 malavon <benny.goemans@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #210375|0 |1 is obsolete| | Attachment #210391| |maintainer-approval+ Flags| | --- Comment #5 from malavon <benny.goemans@gmail.com> --- Created attachment 210391 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D210391&action= =3Dedit Patch to upgrade devilutionX to version 1.0.0 and fix issues post review Hi Steve, thanks for the review, I really appreciate it. I've uploaded a modified patch and here are my 2 cents on your review point= s. > LOCALBASE (...) Replaced with PREFIX in the CMAKE_INSTALL_SHAREDIR variable > CMAKE_BUILD_TYPE is already set based on WITH_DEBUG (...) I'm not sure what you mean with this one. Do you mean the NIGHTLY/RELEASE option? These are an upstream thing. What I could do is set the NIGHTLY=3DON option= when WITH_DEBUG is on. Any ideas if this would be a good idea? > (...) __BSD_VISIBLE (...) Yes, that was the hack I had before. I've had some comments on this before. The patch removes these hacks from the port's patches. > (...) remove the OS name from devilutionx.desktop (...) Done. It is indeed better like this. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-242940-7788-ze7ZQ8TgqB>