From owner-svn-ports-head@FreeBSD.ORG  Tue Apr  7 02:07:43 2015
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 68DC0E35;
 Tue,  7 Apr 2015 02:07:43 +0000 (UTC)
Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "abg.ninja", Issuer "Gandi Standard SSL CA 2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id C35DD91E;
 Tue,  7 Apr 2015 02:07:42 +0000 (UTC)
Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id 6daa986c;
 TLS version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO;
 Mon, 6 Apr 2015 20:07:35 -0600 (MDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\))
Subject: Re: svn commit: r383472 - head/audio/muse
From: Adam Weinberger <adamw@adamw.org>
In-Reply-To: <20150407012902.GA22994@FreeBSD.org>
Date: Mon, 6 Apr 2015 20:07:33 -0600
Content-Transfer-Encoding: quoted-printable
Message-Id: <91AB85D3-A8DE-491C-A2D7-4E8D7E1CDC12@adamw.org>
References: <201504061859.t36IxK0v000969@svn.freebsd.org>
 <20150407012902.GA22994@FreeBSD.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
X-Mailer: Apple Mail (2.2070.6)
Cc: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>, svn-ports-head@freebsd.org,
 svn-ports-all@freebsd.org, ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Apr 2015 02:07:43 -0000

> On 6 Apr, 2015, at 19:29, Alexey Dokuchaev <danfe@FreeBSD.org> wrote:
>=20
> On Mon, Apr 06, 2015 at 06:59:20PM +0000, Sunpoet Po-Chuan Hsieh =
wrote:
>> New Revision: 383472
>> URL: https://svnweb.freebsd.org/changeset/ports/383472
>>=20
>> [...]
>> @@ -52,6 +49,6 @@ post-patch:
>>=20
>> post-install:
>> 	@${MKDIR} ${STAGEDIR}${DOCSDIR}
>> -	${INSTALL_DATA} ${PORTDOCS:S,^,${WRKSRC}/,} =
${STAGEDIR}${DOCSDIR}
>> +	(cd ${WRKSRC} && ${INSTALL_DATA} ${PORTDOCS} =
${STAGEDIR}${DOCSDIR})
>=20
> Please do not change working and readable code into equivalent =
less-readable
> one.


${PORTDOCS:S,^,${WRKSRC}/,}

is not readable. Especially not compared to the pseudo-English statement =
into which sunpoet expanded it:

cd ${WRKSRC} && ${INSTALL_DATA} ${PORTDOCS}

Alexey, you've been ramping up the style policing lately. You're not =
getting much attention when you are choosing a different thing to care =
about each day. Pick just one or two topics that are most important to =
you, and work to get those behaviors fixed. Otherwise, sorry bud, you're =
just micro-managing.

# Adam


--=20
Adam Weinberger
adamw@adamw.org
http://www.adamw.org