Date: Sat, 13 Feb 2021 09:42:58 -0700 From: Warner Losh <imp@bsdimp.com> To: Roger Pau Monne <royger@freebsd.org> Cc: U-Boot Mailing List <u-boot@lists.denx.de>, uboot@freebsd.org, Masahiro Yamada <masahiroy@kernel.org>, Simon Glass <sjg@chromium.org>, Michal Simek <michal.simek@xilinx.com>, Wolfgang Wallner <wolfgang.wallner@br-automation.com>, Jan Kiszka <jan.kiszka@siemens.com> Subject: Re: [PATCH 1/2] scripts/check-config.sh: fix to be compatible with BSD sed Message-ID: <CANCZdfoQ6pOorfMxPXQAsSswVxyo7m-ykkn4pSdBQYwSbonWfA@mail.gmail.com> In-Reply-To: <20210213100632.6249-2-royger@FreeBSD.org> References: <20210213100632.6249-1-royger@FreeBSD.org> <20210213100632.6249-2-royger@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Feb 13, 2021 at 3:06 AM Roger Pau Monne <royger@freebsd.org> wrote:
> Fist use extended regexp in order to drop the '\' around the
> parentheses which is not supported by BSD sed in regular mode.
>
> Secondly use [[:blank:]] instead of \s, as the later is a GNU
> extension.
>
> No functional change intended.
>
> Signed-off-by: Roger Pau Monn=C3=A9 <royger@FreeBSD.org>
>
Reviewed by: Warner Losh <imp@FreeBSD.org>
> ---
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
> Cc: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> scripts/check-config.sh | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/check-config.sh b/scripts/check-config.sh
> index 583f7d0963..cc1c9a54d9 100755
> --- a/scripts/check-config.sh
> +++ b/scripts/check-config.sh
> @@ -39,14 +39,14 @@ new_adhoc=3D"${path}.adhoc"
> export LC_ALL=3DC
> export LC_COLLATE=3DC
>
> -cat ${path} |sed -n 's/^#define \(CONFIG_[A-Za-z0-9_]*\).*/\1/p' |sort
> |uniq \
> +cat ${path} |sed -nr 's/^#define (CONFIG_[A-Za-z0-9_]*).*/\1/p' |sort
> |uniq \
> >${configs}
>
> comm -23 ${configs} ${whitelist} > ${suspects}
>
> -cat `find ${srctree} -name "Kconfig*"` |sed -n \
> - -e 's/^\s*config *\([A-Za-z0-9_]*\).*$/CONFIG_\1/p' \
> - -e 's/^\s*menuconfig \([A-Za-z0-9_]*\).*$/CONFIG_\1/p' \
> +cat `find ${srctree} -name "Kconfig*"` |sed -nr \
> + -e 's/^[[:blank:]]*config *([A-Za-z0-9_]*).*$/CONFIG_\1/p' \
> + -e 's/^[[:blank:]]*menuconfig ([A-Za-z0-9_]*).*$/CONFIG_\1/p' \
> |sort |uniq > ${ok}
> comm -23 ${suspects} ${ok} >${new_adhoc}
> if [ -s ${new_adhoc} ]; then
> --
> 2.30.1
>
> _______________________________________________
> freebsd-uboot@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-uboot
> To unsubscribe, send any mail to "freebsd-uboot-unsubscribe@freebsd.org"
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoQ6pOorfMxPXQAsSswVxyo7m-ykkn4pSdBQYwSbonWfA>