Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 22 Jan 2020 17:44:32 -0800
From:      Gleb Smirnoff <glebius@freebsd.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r357010 - in head/sys: dev/altera/atse dev/beri/virtio/network dev/dpaa dev/hyperv/netvsc dev/if_ndis dev/ntb/if_ntb dev/sbni dev/xen/netback mips/nlm/dev/net net
Message-ID:  <20200123014432.GB1268@FreeBSD.org>
In-Reply-To: <202001230141.00N1fAIQ037940@repo.freebsd.org>
References:  <202001230141.00N1fAIQ037940@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jan 23, 2020 at 01:41:10AM +0000, Gleb Smirnoff wrote:
T> Log:
T>   Introduce flag IFF_NEEDSEPOCH that marks Ethernet interfaces that
T>   supposedly may call into ether_input() without network epoch.
T>   
T>   They all need to be reviewed before 13.0-RELEASE.  Some may need
T>   be fixed.  The flag is not planned to be used in the kernel for
T>   a long time.

One unrelated change crept in:

T> Modified: head/sys/dev/xen/netback/netback.c
T> ==============================================================================
T> --- head/sys/dev/xen/netback/netback.c	Thu Jan 23 01:38:51 2020	(r357009)
T> +++ head/sys/dev/xen/netback/netback.c	Thu Jan 23 01:41:09 2020	(r357010)
T> @@ -780,7 +780,7 @@ xnb_connect_comms(struct xnb_softc *xnb)
T>  					  xnb->evtchn,
T>  					  /*filter*/NULL,
T>  					  xnb_intr, /*arg*/xnb,
T> -					  INTR_TYPE_BIO | INTR_MPSAFE,
T> +					  INTR_TYPE_NET | INTR_MPSAFE,
T>  					  &xnb->xen_intr_handle);
T>  	if (error != 0) {
T>  		(void)xnb_disconnect(xnb);
T> 

The xnb(4) is a network driver, so mark the interrupt appropriately.

-- 
Gleb Smirnoff



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200123014432.GB1268>