From owner-freebsd-stable@FreeBSD.ORG Tue Apr 23 09:29:15 2013 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id E611DC49; Tue, 23 Apr 2013 09:29:15 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-ea0-x22d.google.com (mail-ea0-x22d.google.com [IPv6:2a00:1450:4013:c01::22d]) by mx1.freebsd.org (Postfix) with ESMTP id 55C931235; Tue, 23 Apr 2013 09:29:15 +0000 (UTC) Received: by mail-ea0-f173.google.com with SMTP id m14so148222eaj.18 for ; Tue, 23 Apr 2013 02:29:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=K75q9cIvvT1pqFVSNgIpxBZfbl0GGy0K8D9d90NN0f8=; b=TWoQNwpY8ykCp3ljR1FhxWajOC8QE7lSv9W8ClnWHklrcaNlqragZASjUWwsGogRTM UjOR8NERKsIqmNWUMZyfWxoJd2cxfLBOAsoOM015JhBXFTQYHrWhNjGTXX0fJjaupTa7 Azyezf2TEbw8Vy5OPdCaUJXloGp0SXgik2IWsXM4szaVCXw6nday/q6N3TkoJFEGrsEk tEZzBDAkd2e5iumPMf6ZLDuDX4japDS4JnEVfYoJ0slhQ5T98j6hEkpd1ck0duAGvBMQ tiBJ696f0ux4EwQ2MQwcX7WYjBhbh+95XbHdHj2YR7N9iXq9fpCed5CGD2jwgSCKC2jz 0DBw== X-Received: by 10.14.194.70 with SMTP id l46mr2610199een.28.1366709354291; Tue, 23 Apr 2013 02:29:14 -0700 (PDT) Received: from mavbook.mavhome.dp.ua (mavhome.mavhome.dp.ua. [213.227.240.37]) by mx.google.com with ESMTPS id 8sm45634840eeg.15.2013.04.23.02.29.11 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 23 Apr 2013 02:29:12 -0700 (PDT) Sender: Alexander Motin Message-ID: <51765466.4040209@FreeBSD.org> Date: Tue, 23 Apr 2013 12:29:10 +0300 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130413 Thunderbird/17.0.5 MIME-Version: 1.0 To: Jeremy Chadwick Subject: Re: ada(4) and ahci(4) quirk printing References: <20130422051452.GA2148@icarus.home.lan> <51763BF9.2000506@FreeBSD.org> <20130423092602.GA58831@icarus.home.lan> In-Reply-To: <20130423092602.GA58831@icarus.home.lan> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Kenneth Merry , freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Apr 2013 09:29:16 -0000 On 23.04.2013 12:26, Jeremy Chadwick wrote: > On Tue, Apr 23, 2013 at 10:44:57AM +0300, Alexander Motin wrote: >> On 22.04.2013 08:14, Jeremy Chadwick wrote: >>> I've written the following patches and done the following testing (see >>> the results.*.txt files): >>> >>> http://jdc.koitsu.org/freebsd/quirk_printing/ >>> >>> Important: these are against stable/9 r249715. >>> >>> Folks are welcome to try these; I've tested about as best as I can. >>> >>> Questions/comments for Alexander and Kenneth: >>> >>> 1. I'm not sure if the location of where I added the printf() code is >>> correct or not, >> >> It seems fine for me. >> >>> 2. Not sure if loader.conf(5) forced-quirks would show up here or not, >> >> As I see, they will. >> >>> 3. It would be nice to have the same for SCSI da(4). I took a stab at >>> this but the printing code I wrote never got called (or the quirks entry >>> I added wasn't right, not sure which), >>> >>> 4. I strongly believe quirk printing should be shown *without* verbose >>> booting. I say this because I noticed some of the CAPAB printf()s only >>> get shown if bootverbose is true. In fact, it's what prompted me to >>> open PR 178040 ("My Intel 320 and 510-series SSDs don't show 4K quirks, >>> yet advertise 512 logical and physical in IDENTIFY?! PR time!"). >> >> Let me disagree. bootverbose keeps dmesg readable for average user, >> while quirks are specific driver workarounds and their names may >> confuse more then really help. If every driver print its quirks, >> dmesg would be two times bigger. There is bootverbose for it. > > I'm willing to bend on this assuming that userland has a way to display > the quirks. I've already had one user contact me off-list stating that > displaying of quirks is useful to them, but *without* bootverbose > (because bootverbose shows too much information for them to have to sift > through). And display of quirks (or in this case) was what prompted me > to create PR 178040, since I had just *assumed* FreeBSD had 4K quirks in > place for both models of SSDs. > > I think sysctl would be an ideal place for this. Is it possible to > export active device quirks to sysctl (say kern.cam.ada.X.quirks), > read-only, and preferably as a string (same printf() style used)? Or > does that introduce complexities? > > If we can't reach an agreement, I'm happy to wrap the relevant bits with > an "if (bootverbose)", but I really feel users should have some way to > see this information outside of bootverbose. Both da and ada drivers already have sysctl's. It should be trivial to add one more, especially if just numeric. -- Alexander Motin