From owner-p4-projects@FreeBSD.ORG  Sat Jun 21 09:21:50 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 2F9491065676; Sat, 21 Jun 2008 09:21:50 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E99611065672
	for <perforce@FreeBSD.org>; Sat, 21 Jun 2008 09:21:49 +0000 (UTC)
	(envelope-from weongyo@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id C9FF18FC28
	for <perforce@FreeBSD.org>; Sat, 21 Jun 2008 09:21:49 +0000 (UTC)
	(envelope-from weongyo@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m5L9LnOX006258
	for <perforce@FreeBSD.org>; Sat, 21 Jun 2008 09:21:49 GMT
	(envelope-from weongyo@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m5L9Lnca006256
	for perforce@freebsd.org; Sat, 21 Jun 2008 09:21:49 GMT
	(envelope-from weongyo@FreeBSD.org)
Date: Sat, 21 Jun 2008 09:21:49 GMT
Message-Id: <200806210921.m5L9Lnca006256@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	weongyo@FreeBSD.org using -f
From: Weongyo Jeong <weongyo@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 143872 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 21 Jun 2008 09:21:50 -0000

http://perforce.freebsd.org/chv.cgi?CH=143872

Change 143872 by weongyo@weongyo_ws on 2008/06/21 09:21:43

	don't force short transfers if the xfer directions are to OUT.
	Sometimes allowing short transfers to OUT makes problems such as 
	failing USB's firmware loading.

Affected files ...

.. //depot/projects/ndisusb/sys/compat/ndis/subr_usbd.c#6 edit

Differences ...

==== //depot/projects/ndisusb/sys/compat/ndis/subr_usbd.c#6 (text+ko) ====

@@ -978,7 +978,6 @@
 			    USBD_NO_TIMEOUT, usbd_xfereof);
 		} else {
 			/* TX (bulk OUT)  */
-			xfer->flags |= USBD_FORCE_SHORT_XFER;
 			xfer->flags |= USBD_NO_COPY;
 
 			usbd_setup_xfer(xfer, sc->ndisusb_ep[NDISUSB_ENDPT_BOUT],
@@ -993,8 +992,6 @@
 		    UE_GET_XFERTYPE(ep->bmAttributes),
 		    UE_GET_DIR(ep->bEndpointAddress)));
 
-		xfer->flags |= USBD_FORCE_SHORT_XFER;
-
 		usbd_setup_xfer(xfer, sc->ndisusb_ep[NDISUSB_ENDPT_IOUT],
 		    ip, xfer->buffer, xfer->length, xfer->flags,
 		    NDISUSB_INTR_TIMEOUT, usbd_xfereof);