From owner-freebsd-stable@freebsd.org Thu Apr 18 21:05:05 2019 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 66512157C6D2 for ; Thu, 18 Apr 2019 21:05:05 +0000 (UTC) (envelope-from jamie@catflap.org) Received: from donotpassgo.dyslexicfish.net (donotpassgo.dyslexicfish.net [IPv6:2001:19f0:300:2185:123::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D250D810A6 for ; Thu, 18 Apr 2019 21:05:04 +0000 (UTC) (envelope-from jamie@catflap.org) Received: from donotpassgo.dyslexicfish.net (donotpassgo.dyslexicfish.net [104.207.135.49]) by donotpassgo.dyslexicfish.net (8.14.5/8.14.5) with ESMTP id x3IL514t095013; Thu, 18 Apr 2019 22:05:01 +0100 (BST) (envelope-from jamie@donotpassgo.dyslexicfish.net) Received: (from jamie@localhost) by donotpassgo.dyslexicfish.net (8.14.5/8.14.5/Submit) id x3IL50FW095012; Thu, 18 Apr 2019 22:05:00 +0100 (BST) (envelope-from jamie) From: Jamie Landeg-Jones Message-Id: <201904182105.x3IL50FW095012@donotpassgo.dyslexicfish.net> Date: Thu, 18 Apr 2019 22:05:00 +0100 Organization: Dyslexic Fish To: peter@holm.cc, mckusick@mckusick.com Cc: jamie@catflap.org, jamie@catflap.dyslexicfish.net, imp@bsdimp.com, freebsd-stable@freebsd.org Subject: Re: Replicable file-system corruption due to fsck/ufs References: <201904131341.x3DDfjWf090153@chez.mckusick.com> In-Reply-To: <201904131341.x3DDfjWf090153@chez.mckusick.com> User-Agent: Heirloom mailx 12.4 7/29/08 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.2.7 (donotpassgo.dyslexicfish.net [104.207.135.49]); Thu, 18 Apr 2019 22:05:02 +0100 (BST) X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Apr 2019 21:05:05 -0000 Kirk McKusick wrote: > > From: Peter Holm > > > > On Fri, Apr 12, 2019 at 04:13:00PM -0700, Kirk McKusick wrote: > > > >> This is indeed a bug in the calculation of the location of the last > >> block of a file. I believe that the following patch to head will > >> fix it. > >> > >> Peter, can you please test and let me know. > >> > >> If Peter confirms that it fixes the bug, I will check it into head > >> and MFC it to 12-stable and 11-stable after a 2-week settle-in time. > >> > >> Kirk McKusick > > > > Yes, this patch works for me. > > > > -- > > Peter > > Great, thanks for the quick test. Now committed to head as -r346185. Apologies for the delay in replying. Thanks Kirk for fixing this, and thanks Peter for testing it. The patch also applied cleanly to 12-stable, and is working there too. Cheers, Jamie