From owner-freebsd-arch Fri Aug 31 12:44:29 2001 Delivered-To: freebsd-arch@freebsd.org Received: from kawoserv.kawo2.rwth-aachen.de (kawoserv.kawo2.RWTH-Aachen.DE [134.130.180.1]) by hub.freebsd.org (Postfix) with ESMTP id EC82B37B403; Fri, 31 Aug 2001 12:44:24 -0700 (PDT) Received: from fump.kawo2.rwth-aachen.de (root@fump.kawo2.rwth-aachen.de [134.130.181.148]) by kawoserv.kawo2.rwth-aachen.de (8.9.3/8.9.3) with ESMTP id VAA32542; Fri, 31 Aug 2001 21:44:24 +0200 Received: (from alex@localhost) by fump.kawo2.rwth-aachen.de (8.11.3/8.11.3) id f7VJiPC17563; Fri, 31 Aug 2001 21:44:26 +0200 (CEST) (envelope-from alex) Date: Fri, 31 Aug 2001 21:44:25 +0200 From: Alexander Langer To: "David O'Brien" Cc: Ruslan Ermilov , arch@FreeBSD.ORG Subject: Re: cvs commit: src/share/mk sys.mk Message-ID: <20010831214424.B17435@fump.kawo2.rwth-aachen.de> References: <200108311118.f7VBIO124920@freefall.freebsd.org> <20010831142958.A60910@sunbay.com> <20010831141746.A1809@zerogravity.kawo2.rwth-aachen.d> <20010831084811.B95710@dragon.nuxi.com> <20010831184945.A16872@fump.kawo2.rwth-aachen.de> <20010831100216.A17397@dragon.nuxi.com> <20010831193947.A17086@fump.kawo2.rwth-aachen.de> <20010831110121.B21276@dragon.nuxi.com> <20010831202529.B17086@fump.kawo2.rwth-aachen.de> <20010831115300.A21541@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010831115300.A21541@dragon.nuxi.com>; from obrien@FreeBSD.ORG on Fri, Aug 31, 2001 at 11:53:00AM -0700 X-PGP-Fingerprint: 44 28 CA 4C 46 5B D3 A8 A8 E3 BA F3 4E 60 7D 7F X-PGP-at: finger alex@big.endian.de X-Verwirrung: Dieser Header dient der allgemeinen Verwirrung. Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Thus spake David O'Brien (obrien@FreeBSD.ORG): > > @@ -489,6 +489,10 @@ > > > > _PREMKINCLUDED= yes > > > > +.if exists(/etc/ports.conf) > > +.include > > +.endif > This is what I expected. Has this been tested? Well, not well enought, it seems (see below): It's in my tree now, with my various options (e.g. XFREE86_VERSION=4), and stuff like XFREE86 OR WANT_GTK works flawlessly. > Someone mentioned, > correctly, on ports@ that ports.conf will be read after the invidual > port's Makefile, where as /etc/make.conf is read before. How does this > affect the typical values that one might put in ports.conf? I just noticed a fail-test, e.g. .if defined(WITHOUT_X11) CONFIGURE_ARGS+= --without-x11 .endif if occuring before bsd.port.mk was included. At the moment I don't see a solution for this w/o hacking sys.mk. (Alex, this is _BAD_!) > > I also don't really like it in sys.mk. > Why? Pollution of sys.mk with such stuff. Still seems to be the best place, though. > > However, bsd.prog.mk could be a correct place, though I don't like to > > pollution of this file with a variable like this. > bsd.prog.mk is not used for all make invocations. Correct. Alex To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message