From owner-freebsd-current@FreeBSD.ORG Wed Apr 27 02:57:59 2005 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 60B2116A4CE for ; Wed, 27 Apr 2005 02:57:59 +0000 (GMT) Received: from ns1.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id EF3D543D5E for ; Wed, 27 Apr 2005 02:57:58 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from [192.168.4.250] (dhcp50.pn.xcllnt.net [192.168.4.250]) by ns1.xcllnt.net (8.13.3/8.13.3) with ESMTP id j3R2vonT038033; Tue, 26 Apr 2005 19:57:50 -0700 (PDT) (envelope-from marcel@xcllnt.net) In-Reply-To: <426EF6BD.6030207@errno.com> References: <200504261143.55195.josemi@redesjm.local> <20050426194208.GB7773@ns1.xcllnt.net> <426E9E1C.6020609@errno.com> <20050426221922.GD8621@ns1.xcllnt.net> <426EF6BD.6030207@errno.com> Mime-Version: 1.0 (Apple Message framework v622) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: <05b71132f579685de0459a3b762b26b5@xcllnt.net> Content-Transfer-Encoding: 7bit From: Marcel Moolenaar Date: Tue, 26 Apr 2005 19:57:49 -0700 To: Sam Leffler X-Mailer: Apple Mail (2.622) cc: freebsd-current@freebsd.org cc: Jose M Rodriguez Subject: Re: rigth crc32 implementation X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Apr 2005 02:57:59 -0000 On Apr 26, 2005, at 7:19 PM, Sam Leffler wrote: > Marcel Moolenaar wrote: >> On Tue, Apr 26, 2005 at 01:01:32PM -0700, Sam Leffler wrote: >>> Note also there is CRC32 code of this sort in WEP and TKIP crypto >>> modules in the net80211 support. >> Sam, >> Given the seperation of crc32() into crc32_raw() and crc32(), with >> either crc32() only or otherwise both functions inlined, are there >> any obstacles preventing the 802.11 code from using the ones in >> src/sys/libkern? > > The wep+tkip usage is integral to the cipher so splitting it out would > likely slow them and, more importantly, would also require > revalidation (there are test vectors but they're pretty limited). > These modules are self-contained for various reasons so I'm leary of > switching. Understood. Seems like a good reason to leave it as-is. > I'll think about adding it under an #ifdef for those that want to > save 2Kbytes (the size of the crc tables). In my book, 2K isn't worth the trouble. Thanks for the info, -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net